Issue 1180933002: Revert of Ensure the new navigation classifier works in the real world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1180933002: Revert of Ensure the new navigation classifier works in the real world. (Closed)

Created:
5 years, 6 months ago by Avi (use Gerrit)

Modified:
5 years, 6 months ago

Reviewers:
Robert Sesek, Charlie Reis

CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Ensure the new navigation classifier works in the real world. (patchset #2 id:20001 of https://codereview.chromium.org/1171973004/) Reason for revert: We have an explanation. Original issue's description: > Ensure the new navigation classifier works in the real world. > > BUG=369661 > TEST=No whammies! > > Committed: https://crrev.com/39825ed5795d26cc69167c1fe774f23117cc8f77 > Cr-Commit-Position: refs/heads/master@{#333755} TBR=creis@chromium.org,rsesek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369661 Committed: https://crrev.com/b1986b1606b6a31f7a92e2fa7dcd8be804c8f7e5 Cr-Commit-Position: refs/heads/master@{#334027}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -92 lines)			Patch
M	chrome/common/crash_keys.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl.cc	View	10 chunks	+4 lines, -49 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	5 chunks	+4 lines, -22 lines	0 comments	Download

Total messages: 4 (0 generated)

Avi (use Gerrit)

Created Revert of Ensure the new navigation classifier works in the real world.

5 years, 6 months ago (2015-06-11 20:18:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180933002/1

5 years, 6 months ago (2015-06-11 20:19:24 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-11 20:22:26 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b1986b1606b6a31f7a92e2fa7dcd8be804c8f7e5
Cr-Commit-Position: refs/heads/master@{#334027}