Source/bindings/core/v8/BindingSecurity.cpp - Issue 1180923003: Add window access checks for Suborigins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/BindingSecurity.cpp

Issue 1180923003: Add window access checks for Suborigins (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix tests on Windows Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/BindingSecurity.cpp

diff --git a/Source/bindings/core/v8/BindingSecurity.cpp b/Source/bindings/core/v8/BindingSecurity.cpp

index 6cf718f525d152abe43584f5d8645001c4fc288e..dc00895324b5f7627e079c8e07c86845867d7dcc 100644

--- a/Source/bindings/core/v8/BindingSecurity.cpp

+++ b/Source/bindings/core/v8/BindingSecurity.cpp

@@ -43,7 +43,7 @@ namespace blink {

static bool isOriginAccessibleFromDOMWindow(SecurityOrigin* targetOrigin, LocalDOMWindow* callingWindow)

{

- return callingWindow && callingWindow->document()->securityOrigin()->canAccess(targetOrigin);

+ return callingWindow && callingWindow->document()->securityOrigin()->canAccessCheckSuborigins(targetOrigin);

}

static bool canAccessFrame(v8::Isolate* isolate, SecurityOrigin* targetFrameOrigin, DOMWindow* targetWindow, ExceptionState& exceptionState)