Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1180903010: Fix GCC warning in heap-profile-table.cc. (Closed)

Created:
5 years, 6 months ago by Thiemo Nagel
Modified:
5 years, 6 months ago
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GCC warning in heap-profile-table.cc. The current code throws the following warning: ../../third_party/tcmalloc/chromium/src/heap-profile-table.cc:522:42: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'const void*' [-Wformat=] BUG=None Committed: https://crrev.com/9460c33b35c889740a3dc659eb9c9d1161fd155d Cr-Commit-Position: refs/heads/master@{#334813}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Jochen's comment. #

Patch Set 3 : Fix for the fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/tcmalloc/chromium/src/heap-profile-table.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
Thiemo Nagel
Hi Jochen, could you please take a look? Cheers, Thiemo
5 years, 6 months ago (2015-06-17 09:43:20 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1180903010/diff/1/third_party/tcmalloc/chromium/src/heap-profile-table.cc File third_party/tcmalloc/chromium/src/heap-profile-table.cc (right): https://codereview.chromium.org/1180903010/diff/1/third_party/tcmalloc/chromium/src/heap-profile-table.cc#newcode522 third_party/tcmalloc/chromium/src/heap-profile-table.cc:522: snprintf(addr, 16, "0x%08" PRIxPTR, (uintptr_t)ptr); please use reinterpret_cast<intptr_t>
5 years, 6 months ago (2015-06-17 09:48:09 UTC) #3
Thiemo Nagel
Thank you! https://codereview.chromium.org/1180903010/diff/1/third_party/tcmalloc/chromium/src/heap-profile-table.cc File third_party/tcmalloc/chromium/src/heap-profile-table.cc (right): https://codereview.chromium.org/1180903010/diff/1/third_party/tcmalloc/chromium/src/heap-profile-table.cc#newcode522 third_party/tcmalloc/chromium/src/heap-profile-table.cc:522: snprintf(addr, 16, "0x%08" PRIxPTR, (uintptr_t)ptr); On 2015/06/17 ...
5 years, 6 months ago (2015-06-17 11:22:46 UTC) #4
jochen (gone - plz use gerrit)
On 2015/06/17 at 11:22:46, tnagel wrote: > Thank you! > > https://codereview.chromium.org/1180903010/diff/1/third_party/tcmalloc/chromium/src/heap-profile-table.cc > File third_party/tcmalloc/chromium/src/heap-profile-table.cc ...
5 years, 6 months ago (2015-06-17 11:27:34 UTC) #5
Thiemo Nagel
> > Just out of curiosity: Why do you prefer intptr_t over uintptr_t? > > ...
5 years, 6 months ago (2015-06-17 11:32:52 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-17 11:37:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180903010/40001
5 years, 6 months ago (2015-06-17 11:49:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-17 12:09:34 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 12:10:25 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9460c33b35c889740a3dc659eb9c9d1161fd155d
Cr-Commit-Position: refs/heads/master@{#334813}

Powered by Google App Engine
This is Rietveld 408576698