Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1180893003: net: Remove npapi entry from DEPS file. (Closed)

Created:
5 years, 6 months ago by tfarina
Modified:
5 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, Lei Zhang, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Remove npapi entry from DEPS file. Nothing in net/base is including from third_party/npapi. This also removes zlib from the DEPS file since it is also not included in net/base. BUG=493212 R=mattm@chromium.org Committed: https://crrev.com/bbbe53c8fd162a8645c847b0bef125574b987f94 Cr-Commit-Position: refs/heads/master@{#334306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M net/base/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
5 years, 6 months ago (2015-06-12 22:56:09 UTC) #1
mattm
Seems fine, though this is removing zlib also which isn't mentioned in the description. (Which ...
5 years, 6 months ago (2015-06-12 23:50:22 UTC) #2
tfarina
Another look please?
5 years, 6 months ago (2015-06-13 00:26:15 UTC) #3
mattm
lgtm
5 years, 6 months ago (2015-06-13 00:26:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180893003/1
5 years, 6 months ago (2015-06-13 00:42:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-13 00:50:38 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-13 00:51:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbbe53c8fd162a8645c847b0bef125574b987f94
Cr-Commit-Position: refs/heads/master@{#334306}

Powered by Google App Engine
This is Rietveld 408576698