Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1180883002: Subzero: Fix lit and cross tests broken in f8b4cc8. (Closed)

Created:
5 years, 6 months ago by Jim Stichnoth
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix lit and cross tests broken in f8b4cc8. 1. The data symbol __Sz_block_profile_info should never be mangled (for cross tests), similar to runtime helper calls. Add a SuppressMangling override for such variable declarations. 2. When cross tests contain more than one translated object file, we end up with multiple definitions of __Sz_block_profile_info . Work around this by making that symbol weak. 3. Don't try to attach global inits to an EmitterWorkItem that represents a translation error. 4. Update one lit test to reflect the additional profiling value in the data section. 5. Update one lit test to reflect that global initializers are emitted at the end instead of the beginning. The check-unit test is still broken and will be fixed in a separate CL. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d9f1f9fcb8f0ffe72e52722e26b735386db5fb3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -79 lines) Patch
M pydir/crosstest.py View 1 chunk +9 lines, -0 lines 0 comments Download
M src/IceGlobalContext.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/IceGlobalInits.h View 2 chunks +9 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/elf_container.ll View 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 2 chunks +77 lines, -76 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 6 months ago (2015-06-11 17:02:25 UTC) #2
Karl
lgtm
5 years, 6 months ago (2015-06-11 17:13:53 UTC) #3
Karl
lgtm
5 years, 6 months ago (2015-06-11 17:14:02 UTC) #4
Jim Stichnoth
5 years, 6 months ago (2015-06-11 17:19:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9f1f9fcb8f0ffe72e52722e26b735386db5fb3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698