Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Issue 1180863002: [turbofan] Prefer add/shift over madd on ARM64 (Closed)

Created:
5 years, 6 months ago by martyn.capewell
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Prefer add/shift over madd on ARM64 Before selecting multiply-accumulate for a multiplication with add operation, check that the multiply can't be reduced to add-with-shift. This prevents simple multiplications by 3, 5, etc turning into register moves and madd instructions. Committed: https://crrev.com/b702cd97d450dad496a053eed613abed642d7656 Cr-Commit-Position: refs/heads/master@{#28976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -52 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 9 chunks +88 lines, -52 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +192 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
martyn.capewell
5 years, 6 months ago (2015-06-11 16:25:20 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-12 04:36:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180863002/1
5 years, 6 months ago (2015-06-12 04:36:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 05:01:04 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 05:01:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b702cd97d450dad496a053eed613abed642d7656
Cr-Commit-Position: refs/heads/master@{#28976}

Powered by Google App Engine
This is Rietveld 408576698