Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1180843010: DevTools: Optimize events overview drawing performance (Closed)

Created:
5 years, 6 months ago by alph
Modified:
5 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Optimize events overview drawing performance + hoist window.devicePixelRatio out of loops + do not update overview pane when its width is not changed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 7 chunks +11 lines, -8 lines 0 comments Download
M Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
alph
5 years, 6 months ago (2015-06-18 10:12:29 UTC) #2
yurys
lgtm
5 years, 6 months ago (2015-06-18 10:17:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180843010/1
5 years, 6 months ago (2015-06-18 13:34:13 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 16:17:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197365

Powered by Google App Engine
This is Rietveld 408576698