Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1180843006: [DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg, gavinp+loader_chromium.org, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Add dialog type and return value to Page.javascriptDialog{Opening,Closed}. BUG=486679 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197190

Patch Set 1 #

Patch Set 2 : hidden #

Patch Set 3 : frontend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -54 lines) Patch
M LayoutTests/inspector-protocol/page/javascriptDialogEvents.html View 1 chunk +4 lines, -3 lines 0 comments Download
M LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 2 chunks +19 lines, -4 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/ChromeClient.cpp View 4 chunks +14 lines, -27 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 chunks +12 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Could you please take a look?
4 years, 10 months ago (2015-06-16 16:57:34 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2015-06-16 18:32:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180843006/30001
4 years, 10 months ago (2015-06-16 18:41:04 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 20:26:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197190

Powered by Google App Engine
This is Rietveld 408576698