Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 1180843005: Change private API names and return type in FocusController (Closed)

Created:
4 years, 10 months ago by kochi
Modified:
4 years, 10 months ago
Reviewers:
hayato
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Change private API names and return type in FocusController This renames private API names in FocusController, to return Element instead of Node. No functional change is included. This is a part of code cleanup that focused node should be Element. This is a second half of https://codereview.chromium.org/1177373002/ BUG=499667 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197425

Patch Set 1 #

Patch Set 2 : more conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -79 lines) Patch
M Source/core/page/FocusController.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 20 chunks +69 lines, -75 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180843005/1
4 years, 10 months ago (2015-06-16 06:49:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180843005/20001
4 years, 10 months ago (2015-06-16 07:05:29 UTC) #5
kochi
PTAL
4 years, 10 months ago (2015-06-16 07:07:24 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-16 08:33:25 UTC) #8
hayato
lgtm
4 years, 10 months ago (2015-06-19 01:23:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180843005/20001
4 years, 10 months ago (2015-06-19 02:04:29 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 03:22:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197425

Powered by Google App Engine
This is Rietveld 408576698