Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: content/browser/indexed_db/leveldb/leveldb_database.cc

Issue 1180803003: IndexedDB: Added UMA stat to measure time to close backing store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/indexed_db/leveldb/leveldb_database.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/leveldb/leveldb_database.cc
diff --git a/content/browser/indexed_db/leveldb/leveldb_database.cc b/content/browser/indexed_db/leveldb/leveldb_database.cc
index 459a16e473a529d083775ca368415855572a5a34..2c18f1f5170f34448b4d01f43f28bb82913ed6ab 100644
--- a/content/browser/indexed_db/leveldb/leveldb_database.cc
+++ b/content/browser/indexed_db/leveldb/leveldb_database.cc
@@ -86,11 +86,20 @@ LevelDBDatabase::LevelDBDatabase() {}
LevelDBDatabase::~LevelDBDatabase() {
dgrogan 2015/06/18 22:15:58 Mainly for my edification: Looks like this gets c
cmumford 2015/06/18 22:20:14 Yes, timer is still in IndexedDBFactoryImpl::Relea
// db_'s destructor uses comparator_adapter_; order of deletion is important.
- db_.reset();
+ CloseDatabase();
comparator_adapter_.reset();
env_.reset();
}
+void LevelDBDatabase::CloseDatabase() {
+ if (db_) {
+ base::TimeTicks begin_time = base::TimeTicks::Now();
+ db_.reset();
+ UMA_HISTOGRAM_MEDIUM_TIMES("WebCore.IndexedDB.LevelDB.CloseTime",
+ base::TimeTicks::Now() - begin_time);
+ }
+}
+
static leveldb::Status OpenDB(
leveldb::Comparator* comparator,
leveldb::Env* env,
« no previous file with comments | « content/browser/indexed_db/leveldb/leveldb_database.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698