Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 11808004: Merge 138994 (Closed)

Created:
8 years, 2 months ago by Justin Novosad
Modified:
8 years, 2 months ago
Reviewers:
junov1
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 138994 > Fixing memory read after free in CanvasRenderingContext2D::accessFont > https://bugs.webkit.org/show_bug.cgi?id=106244 > > Reviewed by Abhishek Arya. > > Source/WebCore: > > Using a temporary String object to hold ref count on string that is > passed by reference in CanvasRenderingContext2D::accessFont. > > Test: fast/canvas/canvas-measureText.html > > * html/canvas/CanvasRenderingContext2D.cpp: > (WebCore::CanvasRenderingContext2D::accessFont): > > LayoutTests: > > New test case to verify stability of 2D canvas method measureText. > Test case was causing a DumpRenderTree crash on builds with > AddressSantitizer instrumentation. > > * fast/canvas/canvas-measureText-expected.txt: Added. > * fast/canvas/canvas-measureText.html: Added. > TBR=junov@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
A + LayoutTests/fast/canvas/canvas-measureText.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/canvas/canvas-measureText-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Justin Novosad
8 years, 2 months ago (2013-01-08 16:05:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698