Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: Source/core/dom/Document.idl

Issue 1180793002: Document attribute charset and its aliases to return UTF-8 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated expectation file with UTF-8 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.idl
diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
index a27bc8a8b529bb5d5825558646f1f5656b279ed1..50bf456aa1ab93d5f65598cbb1491565c99404d9 100644
--- a/Source/core/dom/Document.idl
+++ b/Source/core/dom/Document.idl
@@ -38,10 +38,9 @@ interface Document : Node {
[ImplementedAs=url] readonly attribute DOMString? documentURI;
readonly attribute DOMString origin;
readonly attribute DOMString compatMode;
- // FIXME: characterSet should not be nullable.
- readonly attribute DOMString? characterSet;
- // FIXME: inputEncoding should not be nullable.
- [MeasureAs=DocumentInputEncoding, ImplementedAs=characterSet] readonly attribute DOMString? inputEncoding; // legacy alias of .characterSet
+
+ readonly attribute DOMString characterSet;
+ [MeasureAs=DocumentInputEncoding, ImplementedAs=characterSet] readonly attribute DOMString inputEncoding; // legacy alias of .characterSet
readonly attribute DOMString contentType;
readonly attribute DocumentType? doctype;
@@ -196,8 +195,8 @@ interface Document : Node {
readonly attribute VisibilityState visibilityState;
// Non-standard APIs
- [MeasureAs=DocumentCharset, TreatReturnedNullStringAs=Undefined] readonly attribute DOMString charset;
- [MeasureAs=DocumentDefaultCharset, TreatReturnedNullStringAs=Undefined] readonly attribute DOMString defaultCharset;
+ [MeasureAs=DocumentCharset] readonly attribute DOMString charset;
+ [MeasureAs=DocumentDefaultCharset] readonly attribute DOMString defaultCharset;
[MeasureAs=DocumentCaretRangeFromPoint] Range caretRangeFromPoint([Default=Undefined] optional long x, [Default=Undefined] optional long y);
[DeprecateAs=DocumentGetCSSCanvasContext] RenderingContext getCSSCanvasContext(DOMString contextId, DOMString name, long width, long height);

Powered by Google App Engine
This is Rietveld 408576698