LayoutTests/fast/dom/document-attribute-js-null.html - Issue 1180793002: Document attribute charset and its aliases to return UTF-8

Side by Side Diff: LayoutTests/fast/dom/document-attribute-js-null.html

Issue 1180793002: Document attribute charset and its aliases to return UTF-8 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed defaultCharset changes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/dom/xhtml/level3/core/documentgetinputencoding02.js ('K') | « LayoutTests/dom/xhtml/level3/core/documentgetinputencoding02.js ('k') | LayoutTests/fast/dom/document-attribute-js-null-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <style type="text/css">	3 <style type="text/css">

4 .pass { color: green; }	4 .pass { color: green; }

5 .fail { color: red; }	5 .fail { color: red; }

6 </style>	6 </style>

7 <script>	7 <script>

8 function printOut(msg)	8 function printOut(msg)

9 {	9 {

10 var console = document.getElementById("console");	10 var console = document.getElementById("console");

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 var htmlDoc = document.implementation.createHTMLDocument('A Title');	59 var htmlDoc = document.implementation.createHTMLDocument('A Title');

60 htmlDoc.body = htmlDoc.createElement('body');	60 htmlDoc.body = htmlDoc.createElement('body');

61	61

62 var listing = [	62 var listing = [

63 {	63 {

64 typeName: 'Document',	64 typeName: 'Document',

65 docToUse: xmlDoc,	65 docToUse: xmlDoc,

66 attributes: [	66 attributes: [

67 {name: 'xmlVersion', expectedExceptionCode: 9},	67 {name: 'xmlVersion', expectedExceptionCode: 9},

68 {name: 'documentURI', expectedNull: null},	68 {name: 'documentURI', expectedNull: null},

69 {name: 'charset', expectedNull: undefined},	69 {name: 'charset', expectedNull: 'UTF-8'},
	dominicc (has gone to gerrit) 2015/06/22 01:23:31 I think the case of this is wrong per https://enco I think the case of this is wrong per https://encoding.spec.whatwg.org/#names-and-labels Habib Virji 2015/06/22 14:07:30 Yes it does not match it as utf-8, but these test Show quoted text On 2015/06/22 01:23:31, dominicc wrote: > I think the case of this is wrong per > https://encoding.spec.whatwg.org/#names-and-labels Yes it does not match it as utf-8, but these test was to show it does not return nullvalue. I can work on following CL to make UTF8Encoding() handle possible different values as per the specification. philipj_slow 2015/06/23 08:32:56 Actually https://dom.spec.whatwg.org/#dom-document Show quoted text On 2015/06/22 01:23:31, dominicc wrote: > I think the case of this is wrong per > https://encoding.spec.whatwg.org/#names-and-labels Actually https://dom.spec.whatwg.org/#dom-document-characterset special-cases a bunch of encoding to use uppercase labels instead. I'm pretty sure Anne would be happy to always return a lowercase value if there's implementor interest to make that change. Not in this CL, though.
	70 {name: 'defaultCharset', expectedNull: undefined},

	71 {name: 'characterSet', expectedNull: 'UTF-8'},

	72 {name: 'inputEncoding', expectedNull: 'UTF-8'},

70 {name: 'selectedStylesheetSet', expectedNull: null}	73 {name: 'selectedStylesheetSet', expectedNull: null}

71 ]	74 ]

72 },	75 },

73 {	76 {

74 typeName: 'HTMLDocument',	77 typeName: 'HTMLDocument',

75 docToUse: htmlDoc,	78 docToUse: htmlDoc,

76 attributes: [	79 attributes: [

77 {name: 'title', expectedNull: ''},	80 {name: 'title', expectedNull: ''},

78 {name: 'cookie', expectedNull: ''},	81 {name: 'cookie', expectedNull: ''},

79 {name: 'bgColor', expectedNull: ''},	82 {name: 'bgColor', expectedNull: ''},

(...skipping 17 matching lines...) Expand all Loading...
97 printOut('');	100 printOut('');

98 }	101 }

99 }	102 }

100 </script>	103 </script>

101 </head>	104 </head>

102 <body onload="runTests()">	105 <body onload="runTests()">

103 <p>This test setting various attributes of documents to JavaScript null.</p>	106 <p>This test setting various attributes of documents to JavaScript null.</p>

104 <div id="console"></div>	107 <div id="console"></div>

105 </body>	108 </body>

106 </html>	109 </html>

OLD	NEW