Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: src/lookup.cc

Issue 1180753005: Cleanup typed array setters, the property is guaranteed to be there. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/elements.h ('K') | « src/elements.cc ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index b91ad4c9f4bb9ec1b12db7e548bfac0fe27e2fc0..29c54819fcde8f85b1a7f15e752262be8755083a 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -176,7 +176,7 @@ void LookupIterator::ReconfigureDataProperty(Handle<Object> value,
if (attributes == NONE && !holder->HasDictionaryElements() &&
!holder->HasDictionaryArgumentsElements()) {
ElementsAccessor* accessor = holder->GetElementsAccessor();
- accessor->Set(holder, index(), value);
+ accessor->Set(handle(holder->elements()), index(), value);
} else {
DCHECK(holder->HasFastElements() || holder->HasDictionaryElements() ||
holder->HasSloppyArgumentsElements());
@@ -424,7 +424,7 @@ void LookupIterator::WriteDataValue(Handle<Object> value) {
Handle<JSObject> holder = GetHolder<JSObject>();
if (IsElement()) {
ElementsAccessor* accessor = holder->GetElementsAccessor();
- accessor->Set(holder, index_, value);
+ accessor->Set(handle(holder->elements()), index_, value);
} else if (holder->IsGlobalObject()) {
Handle<GlobalDictionary> property_dictionary =
handle(holder->global_dictionary());
« src/elements.h ('K') | « src/elements.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698