Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1180753005: Cleanup typed array setters, the property is guaranteed to be there. (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup typed array setters, the property is guaranteed to be there. BUG=v8:4137 LOG=n Committed: https://crrev.com/691de97b3fc8c35511d60f8aac30d6d065123d91 Cr-Commit-Position: refs/heads/master@{#29129}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -186 lines) Patch
M src/elements.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/elements.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M src/lookup.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 12 chunks +15 lines, -24 lines 0 comments Download
M src/objects.cc View 1 1 chunk +84 lines, -124 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +12 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-18 09:08:56 UTC) #2
Igor Sheludko
nice! lgtm https://codereview.chromium.org/1180753005/diff/1/src/elements.h File src/elements.h (right): https://codereview.chromium.org/1180753005/diff/1/src/elements.h#newcode178 src/elements.h:178: virtual void Set(Handle<FixedArrayBase> backing_store, uint32_t key, It ...
5 years, 6 months ago (2015-06-18 12:35:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180753005/1
5 years, 6 months ago (2015-06-18 14:05:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/6856)
5 years, 6 months ago (2015-06-18 14:08:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180753005/1
5 years, 6 months ago (2015-06-18 17:01:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1465)
5 years, 6 months ago (2015-06-18 17:02:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180753005/20001
5 years, 6 months ago (2015-06-18 17:06:50 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-18 19:49:36 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 19:49:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/691de97b3fc8c35511d60f8aac30d6d065123d91
Cr-Commit-Position: refs/heads/master@{#29129}

Powered by Google App Engine
This is Rietveld 408576698