Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 1180733005: [DevTools] Added missing items to live anchor's context menu (Closed)

Created:
4 years, 10 months ago by kozy
Modified:
4 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Added missing items to live anchor's context menu Without this CL all live anchors has no href property. With this CL "Open*" items are added for live anchors with network URL. BUG=498744, 501758 R=pfeldman@chromium.org, lushnikov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197485

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M Source/devtools/front_end/bindings/Linkifier.js View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/HandlerRegistry.js View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kozy
Pavel, please take a look!
4 years, 10 months ago (2015-06-17 16:04:51 UTC) #1
pfeldman
https://codereview.chromium.org/1180733005/diff/1/Source/devtools/front_end/bindings/Linkifier.js File Source/devtools/front_end/bindings/Linkifier.js (right): https://codereview.chromium.org/1180733005/diff/1/Source/devtools/front_end/bindings/Linkifier.js#newcode344 Source/devtools/front_end/bindings/Linkifier.js:344: var networkURL = WebInspector.networkMapping.networkURL(uiLocation.uiSourceCode); This is likely a modularity ...
4 years, 10 months ago (2015-06-18 06:51:18 UTC) #2
kozy
Uploaded new iteration. Replaced href with getting uiLocation from anchorElement by _uiLocationSymbol. Please take a ...
4 years, 10 months ago (2015-06-18 13:04:20 UTC) #3
lushnikov
works for me. lets see what @pfeldman will say. https://codereview.chromium.org/1180733005/diff/40001/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/1180733005/diff/40001/Source/devtools/front_end/elements/ElementsPanel.js#newcode848 Source/devtools/front_end/elements/ElementsPanel.js:848: ...
4 years, 10 months ago (2015-06-19 13:16:54 UTC) #6
kozy
Pavel, please take a look! https://codereview.chromium.org/1180733005/diff/40001/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/1180733005/diff/40001/Source/devtools/front_end/elements/ElementsPanel.js#newcode848 Source/devtools/front_end/elements/ElementsPanel.js:848: contextMenu.appendApplicableItems(/** @type {!Object} */ ...
4 years, 10 months ago (2015-06-19 13:52:43 UTC) #7
pfeldman
lgtm
4 years, 10 months ago (2015-06-19 14:52:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180733005/60001
4 years, 10 months ago (2015-06-19 14:53:27 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 16:53:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197485

Powered by Google App Engine
This is Rietveld 408576698