Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1941)

Issue 1180723004: Widen dependencies to match Dart SDK deps (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pubspec.yaml View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
Manually verified each of our constraints was in the valid range. Also checked shelf_static, which ...
5 years, 6 months ago (2015-06-11 20:39:51 UTC) #2
vsm
lgtm!
5 years, 6 months ago (2015-06-11 20:40:52 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1180723004/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1180723004/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.1.1 bumped version because want to publish this ...
5 years, 6 months ago (2015-06-11 20:40:56 UTC) #4
Jennifer Messerly
5 years, 6 months ago (2015-06-11 20:41:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9263b664425ae0862229ac3e969100cc551c6ccb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698