Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Issue 1180713008: Move blend enums into GrBlend.h (Closed)

Created:
5 years, 6 months ago by Chris Dalton
Modified:
5 years, 6 months ago
Reviewers:
bsalomon, egdaniel, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move blend enums into GrBlend.h Moves blend enums from GrXferProcessor.h to GrBlend.h, makes GrBlend.h public. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ee0175f1b0c9099096d90945a985378dbe8e7fd9

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Take out GrXferProcessor.h #

Patch Set 4 : Makd SkTLogic public #

Patch Set 5 : relative include #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -218 lines) Patch
M gyp/gpu.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + include/gpu/GrBlend.h View 1 2 3 4 1 chunk +63 lines, -2 lines 1 comment Download
M include/gpu/GrXferProcessor.h View 2 chunks +1 line, -60 lines 0 comments Download
D src/gpu/GrBlend.h View 1 chunk +0 lines, -155 lines 0 comments Download

Messages

Total messages: 27 (11 generated)
Chris Dalton
5 years, 6 months ago (2015-06-11 17:55:00 UTC) #2
egdaniel
https://codereview.chromium.org/1180713008/diff/1/include/gpu/GrBlend.h File include/gpu/GrBlend.h (right): https://codereview.chromium.org/1180713008/diff/1/include/gpu/GrBlend.h#newcode11 include/gpu/GrBlend.h:11: #include "GrXferProcessor.h" Haven't actually looked, but since you moved ...
5 years, 6 months ago (2015-06-11 18:01:02 UTC) #3
Chris Dalton
https://codereview.chromium.org/1180713008/diff/1/include/gpu/GrBlend.h File include/gpu/GrBlend.h (right): https://codereview.chromium.org/1180713008/diff/1/include/gpu/GrBlend.h#newcode11 include/gpu/GrBlend.h:11: #include "GrXferProcessor.h" On 2015/06/11 18:01:02, egdaniel wrote: > Haven't ...
5 years, 6 months ago (2015-06-11 18:06:25 UTC) #4
bsalomon
lgtm
5 years, 6 months ago (2015-06-11 18:13:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180713008/40001
5 years, 6 months ago (2015-06-11 18:14:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1486)
5 years, 6 months ago (2015-06-11 18:15:21 UTC) #9
Chris Dalton
Adding bungeman for the move of SkTLogic into the public API
5 years, 6 months ago (2015-06-11 18:26:59 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180713008/60001
5 years, 6 months ago (2015-06-11 18:27:44 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1461) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 6 months ago (2015-06-11 18:31:05 UTC) #16
bungeman-skia
I'm not on the list of header file promoters.
5 years, 6 months ago (2015-06-11 18:40:51 UTC) #18
Chris Dalton
5 years, 6 months ago (2015-06-12 15:11:36 UTC) #20
bsalomon
On 2015/06/12 15:11:36, Chris Dalton wrote: lgtm
5 years, 6 months ago (2015-06-12 15:12:25 UTC) #21
Chris Dalton
Adding mtklein for the relative include
5 years, 6 months ago (2015-06-12 15:14:49 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180713008/80001
5 years, 6 months ago (2015-06-12 15:15:46 UTC) #25
mtklein
https://codereview.chromium.org/1180713008/diff/80001/include/gpu/GrBlend.h File include/gpu/GrBlend.h (right): https://codereview.chromium.org/1180713008/diff/80001/include/gpu/GrBlend.h#newcode10 include/gpu/GrBlend.h:10: #include "../../src/utils/SkTLogic.h" Boy this line of code LGTM.
5 years, 6 months ago (2015-06-12 15:15:46 UTC) #26
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 15:21:31 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/ee0175f1b0c9099096d90945a985378dbe8e7fd9

Powered by Google App Engine
This is Rietveld 408576698