Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1180713005: DevTools: speculative fix of crash in PageDebuggerAgent::restore (Closed)

Created:
4 years, 10 months ago by yurys
Modified:
4 years, 10 months ago
Reviewers:
kozy, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: speculative fix of crash in PageDebuggerAgent::restore It may happen that we navigate to a page where script execution is blocked. Debugger should not be anabled for such pages. This CL makes sure that we won't be restoring debugger state if we know for sure that the script execution is blocked. restore() is called very early before the load starts hence at that point we don't know if the new page is blacklisted. This use case is not covered by this change and I'm hesitent complicating debugger code for such rare scenario. BUG=498963 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yurys
4 years, 10 months ago (2015-06-11 10:12:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180713005/1
4 years, 10 months ago (2015-06-11 10:12:32 UTC) #4
sergeyv
lgtm
4 years, 10 months ago (2015-06-11 10:34:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180713005/1
4 years, 10 months ago (2015-06-11 10:58:59 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 11:26:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196937

Powered by Google App Engine
This is Rietveld 408576698