Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java

Issue 1180693002: Update from https://crrev.com/333737 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java
diff --git a/base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java b/base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java
index 89bee996a6fe0fd3a5bf35561cdb470bc2731b72..f54944b1ff24d704c47427a36723579589c94813 100644
--- a/base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java
+++ b/base/android/jni_generator/java/src/org/chromium/example/jni_generator/SampleForTests.java
@@ -92,7 +92,7 @@ import java.util.List;
@JNINamespace("base::android")
class SampleForTests {
// Classes can store their C++ pointer counter part as an int that is normally initialized by
- // calling out a nativeInit() function.
+ // calling out a nativeInit() function. Replace "CPPClass" with your particular class name!
long mNativeCPPObject;
// You can define methods and attributes on the java class just like any other.
@@ -101,7 +101,7 @@ class SampleForTests {
}
public void startExample() {
- // Calls native code and holds a pointer to the C++ class.
+ // Calls C++ Init(...) method and holds a pointer to the C++ class.
mNativeCPPObject = nativeInit("myParam");
}
@@ -187,10 +187,11 @@ class SampleForTests {
// This defines a function binding to the associated C++ class member function. The name is
// derived from |nativeDestroy| and |nativeCPPClass| to arrive at CPPClass::Destroy() (i.e.
- // native
- // prefixes stripped).
- // The |nativeCPPClass| is automatically cast to type CPPClass* in order to obtain the object on
- // which to invoke the member function.
+ // native prefixes stripped).
+ //
+ // The |nativeCPPClass| is automatically cast to type CPPClass*, in order to obtain the object
+ // on
+ // which to invoke the member function. Replace "CPPClass" with your particular class name!
private native void nativeDestroy(long nativeCPPClass);
// This declares a C++ function which the application code must implement:
@@ -203,8 +204,7 @@ class SampleForTests {
private static native float nativeGetFloatFunction();
// This function takes a non-POD datatype. We have a list mapping them to their full classpath
- // in
- // jni_generator.py JavaParamToJni. If you require a new datatype, make sure you add to that
+ // in jni_generator.py JavaParamToJni. If you require a new datatype, make sure you add to that
// function.
private native void nativeSetNonPODDatatype(Rect rect);
@@ -216,8 +216,7 @@ class SampleForTests {
private native Object nativeGetNonPODDatatype();
// Similar to nativeDestroy above, this will cast nativeCPPClass into pointer of CPPClass type
- // and
- // call its Method member function.
+ // and call its Method member function. Replace "CPPClass" with your particular class name!
private native int nativeMethod(long nativeCPPClass);
// Similar to nativeMethod above, but here the C++ fully qualified class name is taken from the
« no previous file with comments | « base/android/java/src/org/chromium/base/library_loader/Linker.java ('k') | base/android/jni_generator/jni_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698