Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2703)

Unified Diff: base/json/json_value_converter_unittest.cc

Issue 1180693002: Update from https://crrev.com/333737 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_string_value_serializer.cc ('k') | base/json/json_value_serializer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_value_converter_unittest.cc
diff --git a/base/json/json_value_converter_unittest.cc b/base/json/json_value_converter_unittest.cc
index 7d48f39a30bb678215ae073bf252879d803c13d7..90386107d85ca2a6f90b3292750ba3135996d558 100644
--- a/base/json/json_value_converter_unittest.cc
+++ b/base/json/json_value_converter_unittest.cc
@@ -106,7 +106,7 @@ TEST(JSONValueConverterTest, ParseSimpleMessage) {
" \"ints\": [1, 2]"
"}\n";
- scoped_ptr<Value> value(base::JSONReader::Read(normal_data));
+ scoped_ptr<Value> value = base::JSONReader::Read(normal_data);
SimpleMessage message;
base::JSONValueConverter<SimpleMessage> converter;
EXPECT_TRUE(converter.Convert(*value.get(), &message));
@@ -148,7 +148,7 @@ TEST(JSONValueConverterTest, ParseNestedMessage) {
" }]\n"
"}\n";
- scoped_ptr<Value> value(base::JSONReader::Read(normal_data));
+ scoped_ptr<Value> value = base::JSONReader::Read(normal_data);
NestedMessage message;
base::JSONValueConverter<NestedMessage> converter;
EXPECT_TRUE(converter.Convert(*value.get(), &message));
@@ -190,7 +190,7 @@ TEST(JSONValueConverterTest, ParseFailures) {
" \"ints\": [1, 2]"
"}\n";
- scoped_ptr<Value> value(base::JSONReader::Read(normal_data));
+ scoped_ptr<Value> value = base::JSONReader::Read(normal_data);
SimpleMessage message;
base::JSONValueConverter<SimpleMessage> converter;
EXPECT_FALSE(converter.Convert(*value.get(), &message));
@@ -206,7 +206,7 @@ TEST(JSONValueConverterTest, ParseWithMissingFields) {
" \"ints\": [1, 2]"
"}\n";
- scoped_ptr<Value> value(base::JSONReader::Read(normal_data));
+ scoped_ptr<Value> value = base::JSONReader::Read(normal_data);
SimpleMessage message;
base::JSONValueConverter<SimpleMessage> converter;
// Convert() still succeeds even if the input doesn't have "bar" field.
@@ -229,7 +229,7 @@ TEST(JSONValueConverterTest, EnumParserFails) {
" \"ints\": [1, 2]"
"}\n";
- scoped_ptr<Value> value(base::JSONReader::Read(normal_data));
+ scoped_ptr<Value> value = base::JSONReader::Read(normal_data);
SimpleMessage message;
base::JSONValueConverter<SimpleMessage> converter;
EXPECT_FALSE(converter.Convert(*value.get(), &message));
@@ -246,7 +246,7 @@ TEST(JSONValueConverterTest, RepeatedValueErrorInTheMiddle) {
" \"ints\": [1, false]"
"}\n";
- scoped_ptr<Value> value(base::JSONReader::Read(normal_data));
+ scoped_ptr<Value> value = base::JSONReader::Read(normal_data);
SimpleMessage message;
base::JSONValueConverter<SimpleMessage> converter;
EXPECT_FALSE(converter.Convert(*value.get(), &message));
« no previous file with comments | « base/json/json_string_value_serializer.cc ('k') | base/json/json_value_serializer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698