Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: testing/chromoting/browser_tests_launcher.py

Issue 1180693002: Update from https://crrev.com/333737 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/chromoting/browser_tests_launcher.py
diff --git a/testing/chromoting/browser_tests_launcher.py b/testing/chromoting/browser_tests_launcher.py
index 1c9652fb513c5c6b576aa214994a50c283a11ac0..d39d2910e3e70ae330e210206d3c250147603c27 100644
--- a/testing/chromoting/browser_tests_launcher.py
+++ b/testing/chromoting/browser_tests_launcher.py
@@ -25,11 +25,45 @@ CHROMOTING_HOST_PATH = '/opt/google/chrome-remote-desktop/chrome-remote-desktop'
TEST_FAILURE = False
FAILING_TESTS = ''
HOST_READY_INDICATOR = 'Host ready to receive connections.'
+BROWSER_NOT_STARTED_ERROR = (
+ 'Still waiting for the following processes to finish')
+TIME_OUT_INDICATOR = '(TIMED OUT)'
+MAX_RETRIES = 1
-def LaunchBTCommand(command):
+def LaunchBTCommand(args, command):
+ """Launches the specified browser-test command.
+
+ If the execution failed because a browser-instance was not launched, retry
+ once.
+ Args:
+ args: Command line args, used for test-case startup tasks.
+ command: Browser-test command line.
+ """
global TEST_FAILURE, FAILING_TESTS
- results = RunCommandInSubProcess(command)
+
+ retries = 0
+ while retries <= MAX_RETRIES:
+ TestCaseSetup(args)
+ results = RunCommandInSubProcess(command)
+
+ if SUCCESS_INDICATOR in results:
+ # Test passed.
+ break
+
+ # Sometimes, during execution of browser-tests, a browser instance is
+ # not started and the test times out. See http://crbug/480025.
+ # To work around it, check if this execution failed owing to that
+ # problem and retry.
+ # There are 2 things to look for in the results:
+ # A line saying "Still waiting for the following processes to finish",
+ # and, because sometimes that line gets logged even if the test
+ # eventually passes, we'll also look for "(TIMED OUT)", before retrying.
+ if not (
+ BROWSER_NOT_STARTED_ERROR in results and TIME_OUT_INDICATOR in results):
+ # Test failed for some other reason. Let's not retry.
+ break
+ retries += 1
# Check that the test passed.
if SUCCESS_INDICATOR not in results:
@@ -173,28 +207,28 @@ def PrintRunningProcesses():
print process.name
+def TestCaseSetup(args):
+ # Stop+start me2me host process.
+ if not RestartMe2MeHost():
+ # Host restart failed. Don't run any more tests.
+ raise Exception('Host restart failed.')
+
+ # Reset the user profile directory to start each test with a clean slate.
+ SetupUserProfileDir(args.me2me_manifest_file, args.it2me_manifest_file,
+ args.user_profile_dir)
+
+
def main(args):
InitialiseTestMachineForLinux(args.cfg_file)
with open(args.commands_file) as f:
for line in f:
- # Reset the user profile directory to start each test with a clean slate.
- SetupUserProfileDir(args.me2me_manifest_file, args.it2me_manifest_file,
- args.user_profile_dir)
-
# Replace the PROD_DIR value in the command-line with
# the passed in value.
line = line.replace(PROD_DIR_ID, args.prod_dir)
# Launch specified command line for test.
- LaunchBTCommand(line)
- # After each test, stop+start me2me host process.
- if not RestartMe2MeHost():
- # Host restart failed. Don't run any more tests.
- raise Exception('Host restart failed.')
-
- # Print list of currently running processes.
- PrintRunningProcesses()
+ LaunchBTCommand(args, line)
# All tests completed. Include host-logs in the test results.
host_log_contents = ''
« no previous file with comments | « testing/chromoting/browser_test_commands_linux.txt ('k') | testing/chromoting/chromoting_integration_tests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698