Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: build/config/clang/BUILD.gn

Issue 1180693002: Update from https://crrev.com/333737 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/arm.gni ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/clang/BUILD.gn
diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn
index e79a7b93d82eb4ea9e74449cc46bb64426f8a792..6dff4863a5e93603a89a1fce1972bb8f1e70d828 100644
--- a/build/config/clang/BUILD.gn
+++ b/build/config/clang/BUILD.gn
@@ -31,13 +31,13 @@ config("find_bad_constructs") {
]
}
- if (is_win) {
- # Don't error on plugin warnings on Windows until pre-existing warnings
- # are cleaned up. https://crbug.com/467287
+ # https://crbug.com/441916
+ if (is_android || is_linux || is_mac) {
cflags += [
"-Xclang",
"-plugin-arg-find-bad-constructs",
- "-Xclang warn-only",
+ "-Xclang",
+ "check-templates",
]
}
« no previous file with comments | « build/config/arm.gni ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698