base/numerics/safe_math_impl.h - Issue 1180693002: Update from https://crrev.com/333737

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/numerics/safe_math_impl.h

Issue 1180693002: Update from https://crrev.com/333737 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebased Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/numerics/safe_math_impl.h

diff --git a/base/numerics/safe_math_impl.h b/base/numerics/safe_math_impl.h

index c8451898bb522681c4d4761cb83a7656e556900f..08f2e88345f34d62870dcf16c569b126304f06f6 100644

--- a/base/numerics/safe_math_impl.h

+++ b/base/numerics/safe_math_impl.h

@@ -176,8 +176,8 @@ typename enable_if<std::numeric_limits<T>::is_integer&& std::numeric_limits<

T>::is_signed&&(sizeof(T) * 2 > sizeof(uintmax_t)),

T>::type

CheckedMul(T x, T y, RangeConstraint* validity) {

- // if either side is zero then the result will be zero.

- if (!(x || y)) {

+ // If either side is zero then the result will be zero.

+ if (!x || !y) {

return RANGE_VALID;

} else if (x > 0) {

« no previous file with comments | « base/numerics/safe_math.h ('k') | base/numerics/safe_numerics_unittest.cc » ('j') | no next file with comments »