Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: base/trace_event/process_memory_maps_dump_provider_unittest.cc

Issue 1180693002: Update from https://crrev.com/333737 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/process_memory_maps_dump_provider.cc ('k') | base/trace_event/process_memory_totals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/process_memory_maps_dump_provider_unittest.cc
diff --git a/base/trace_event/process_memory_maps_dump_provider_unittest.cc b/base/trace_event/process_memory_maps_dump_provider_unittest.cc
index e45d30a65074cd39329ac3c27cb3c5fbf92986f0..5416e119960f790858386de5bafb167d549da6fe 100644
--- a/base/trace_event/process_memory_maps_dump_provider_unittest.cc
+++ b/base/trace_event/process_memory_maps_dump_provider_unittest.cc
@@ -29,7 +29,7 @@ const char kTestSmaps1[] =
"Referenced: 296 kB\n"
"Anonymous: 68 kB\n"
"AnonHugePages: 0 kB\n"
- "Swap: 0 kB\n"
+ "Swap: 4 kB\n"
"KernelPageSize: 4 kB\n"
"MMUPageSize: 4 kB\n"
"Locked: 0 kB\n"
@@ -142,16 +142,22 @@ TEST(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps) {
EXPECT_EQ(kProtR | kProtX, regions_1[0].protection_flags);
EXPECT_EQ("/file/1", regions_1[0].mapped_file);
EXPECT_EQ(162 * 1024UL, regions_1[0].byte_stats_proportional_resident);
- EXPECT_EQ((228 + 0) * 1024UL, regions_1[0].byte_stats_shared_resident);
- EXPECT_EQ((0 + 68) * 1024UL, regions_1[0].byte_stats_private_resident);
+ EXPECT_EQ(228 * 1024UL, regions_1[0].byte_stats_shared_clean_resident);
+ EXPECT_EQ(0UL, regions_1[0].byte_stats_shared_dirty_resident);
+ EXPECT_EQ(0UL, regions_1[0].byte_stats_private_clean_resident);
+ EXPECT_EQ(68 * 1024UL, regions_1[0].byte_stats_private_dirty_resident);
+ EXPECT_EQ(4 * 1024UL, regions_1[0].byte_stats_swapped);
EXPECT_EQ(0xff000000UL, regions_1[1].start_address);
EXPECT_EQ(0xff800000UL - 0xff000000UL, regions_1[1].size_in_bytes);
EXPECT_EQ(kProtW, regions_1[1].protection_flags);
EXPECT_EQ("/file/name with space", regions_1[1].mapped_file);
EXPECT_EQ(128 * 1024UL, regions_1[1].byte_stats_proportional_resident);
- EXPECT_EQ((120 + 4) * 1024UL, regions_1[1].byte_stats_shared_resident);
- EXPECT_EQ((60 + 8) * 1024UL, regions_1[1].byte_stats_private_resident);
+ EXPECT_EQ(120 * 1024UL, regions_1[1].byte_stats_shared_clean_resident);
+ EXPECT_EQ(4 * 1024UL, regions_1[1].byte_stats_shared_dirty_resident);
+ EXPECT_EQ(60 * 1024UL, regions_1[1].byte_stats_private_clean_resident);
+ EXPECT_EQ(8 * 1024UL, regions_1[1].byte_stats_private_dirty_resident);
+ EXPECT_EQ(0 * 1024UL, regions_1[1].byte_stats_swapped);
// Parse the 2nd smaps file.
ProcessMemoryDump pmd_2(nullptr /* session_state */);
@@ -166,8 +172,11 @@ TEST(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps) {
EXPECT_EQ(0U, regions_2[0].protection_flags);
EXPECT_EQ("", regions_2[0].mapped_file);
EXPECT_EQ(32 * 1024UL, regions_2[0].byte_stats_proportional_resident);
- EXPECT_EQ((16 + 12) * 1024UL, regions_2[0].byte_stats_shared_resident);
- EXPECT_EQ((8 + 4) * 1024UL, regions_2[0].byte_stats_private_resident);
+ EXPECT_EQ(16 * 1024UL, regions_2[0].byte_stats_shared_clean_resident);
+ EXPECT_EQ(12 * 1024UL, regions_2[0].byte_stats_shared_dirty_resident);
+ EXPECT_EQ(8 * 1024UL, regions_2[0].byte_stats_private_clean_resident);
+ EXPECT_EQ(4 * 1024UL, regions_2[0].byte_stats_private_dirty_resident);
+ EXPECT_EQ(0 * 1024UL, regions_2[0].byte_stats_swapped);
}
#endif // defined(OS_LINUX) || defined(OS_ANDROID)
« no previous file with comments | « base/trace_event/process_memory_maps_dump_provider.cc ('k') | base/trace_event/process_memory_totals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698