tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.txt - Issue 1180693002: Update from https://crrev.com/333737

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.txt

Issue 1180693002: Update from https://crrev.com/333737 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebased Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp ('k') | tools/clang/blink_gc_plugin/tests/destructor_eagerly_finalized.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 destructor_access_finalized_field.cpp:16:9: warning: [blink-gc] Finalizer '~Heap Object' accesses potentially finalized field 'm_obj'.	1 destructor_access_finalized_field.cpp:18:9: warning: [blink-gc] Finalizer '~Heap Object' accesses potentially finalized field 'm_obj'.

2 bar(m_obj);	2 bar(m_obj);

3 ^	3 ^

4 ./destructor_access_finalized_field.h:25:5: note: [blink-gc] Potentially finaliz ed field 'm_obj' declared here:	4 ./destructor_access_finalized_field.h:38:5: note: [blink-gc] Potentially finaliz ed field 'm_obj' declared here:

5 Member<HeapObject> m_obj;	5 Member<HeapObject> m_obj;

6 ^	6 ^

7 destructor_access_finalized_field.cpp:17:5: warning: [blink-gc] Finalizer '~Heap Object' accesses potentially finalized field 'm_obj'.	7 destructor_access_finalized_field.cpp:19:5: warning: [blink-gc] Finalizer '~Heap Object' accesses potentially finalized field 'm_obj'.

8 m_obj->foo();	8 m_obj->foo();

9 ^	9 ^

10 ./destructor_access_finalized_field.h:25:5: note: [blink-gc] Potentially finaliz ed field 'm_obj' declared here:	10 ./destructor_access_finalized_field.h:38:5: note: [blink-gc] Potentially finaliz ed field 'm_obj' declared here:

11 Member<HeapObject> m_obj;	11 Member<HeapObject> m_obj;

12 ^	12 ^

13 destructor_access_finalized_field.cpp:18:5: warning: [blink-gc] Finalizer '~Heap Object' accesses potentially finalized field 'm_objs'.	13 destructor_access_finalized_field.cpp:20:5: warning: [blink-gc] Finalizer '~Heap Object' accesses potentially finalized field 'm_objs'.

14 m_objs[0];	14 m_objs[0];

15 ^	15 ^

16 ./destructor_access_finalized_field.h:26:5: note: [blink-gc] Potentially finaliz ed field 'm_objs' declared here:	16 ./destructor_access_finalized_field.h:39:5: note: [blink-gc] Potentially finaliz ed field 'm_objs' declared here:

17 Vector<Member<HeapObject> > m_objs;	17 Vector<Member<HeapObject> > m_objs;

18 ^	18 ^

19 3 warnings generated.	19 3 warnings generated.

OLD	NEW