Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: git_common.py

Issue 1180673003: Make git-rebase-update a bit more robust (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_rebase_update.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_common.py
diff --git a/git_common.py b/git_common.py
index a01f8e5694465219af083d5c4b12a5cbaca97a4b..a506fb851f208bbcac1a514d989d631bf6bf6dfb 100644
--- a/git_common.py
+++ b/git_common.py
@@ -525,7 +525,7 @@ def rebase(parent, start, branch, abort=False):
return RebaseRet(True, '', '')
except subprocess2.CalledProcessError as cpe:
if abort:
- run('rebase', '--abort')
+ run_with_retcode('rebase', '--abort') # ignore failure
return RebaseRet(False, cpe.stdout, cpe.stderr)
« no previous file with comments | « no previous file | git_rebase_update.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698