Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 1180663002: Make deferred image decoding default to on. (Closed)

Created:
4 years, 10 months ago by danakj
Modified:
4 years, 10 months ago
CC:
blink-reviews, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr., pdr+graphicswatchlist_chromium.org, piman, Peter Kasting, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make deferred image decoding default to on. It's always enabled with impl-side painting. And impl-side painting is now always on for blink (we recently removed the last hold-out layout tests). https://codereview.chromium.org/1179653004/ removes it as an option on the chromium side and always gives true to setDeferredImageDecodingEnabled. R=schenney@chromium.org BUG=413479 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196969

Patch Set 1 #

Patch Set 2 : deferredon: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSettingsImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
danakj
There are still some test users of DeferredImageDecoder::setEnabled: Source/platform/graphics/BitmapImageTest.cpp:127: Source/web/ImageDecodeBench.cpp:354: Probably some of these should ...
4 years, 10 months ago (2015-06-10 22:56:05 UTC) #1
pdr.
LGTM
4 years, 10 months ago (2015-06-10 23:17:54 UTC) #3
chrishtr
lgtm
4 years, 10 months ago (2015-06-11 00:07:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180663002/20001
4 years, 10 months ago (2015-06-11 00:08:24 UTC) #7
esprehn
lgtm
4 years, 10 months ago (2015-06-11 01:09:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180663002/20001
4 years, 10 months ago (2015-06-11 20:09:10 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 20:12:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196969

Powered by Google App Engine
This is Rietveld 408576698