Refactoring: Remove addDisplayInline parameter of createInlineStyle

Refactoring: Remove addDisplayInline parameter of createInlineStyle

This CL removes |addDisplayInline| parameter of createInlineStyle by
extracting the code when |addDisplayInline| is true at the callers.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196924

[hajimehoshi, 2015-06-11 06:38:32]

Patchset #1 (id:1) has been deleted

[hajimehoshi, 2015-06-11 06:39:02]

hajimehoshi@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[hajimehoshi, 2015-06-11 06:39:02]

PTAL

[yosin_UTC9, 2015-06-11 06:44:39]

tkent@, Could you review this patch? Since, this is result of pair programming
with hajimehoshi@ and yosin@. So, yosin@ is also author.

[tkent, 2015-06-11 06:55:11]

lgtm

https://codereview.chromium.org/1180653005/diff/20001/Source/core/editing/Sty...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1180653005/diff/20001/Source/core/editing/Sty...
Source/core/editing/StyledMarkupAccumulator.cpp:158: if
(!element.isHTMLElement())
nit:

if (element.isHTMLElement() && shouldAnnotate())
    inlineStyle->mergeStyleHogeHoge...
return inlineStyle;

is clearer, I think.

[hajimehoshi, 2015-06-11 07:03:30]

Thank you!

https://codereview.chromium.org/1180653005/diff/20001/Source/core/editing/Sty...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1180653005/diff/20001/Source/core/editing/Sty...
Source/core/editing/StyledMarkupAccumulator.cpp:158: if
(!element.isHTMLElement())
On 2015/06/11 06:55:11, tkent wrote:
> nit:
> 
> if (element.isHTMLElement() && shouldAnnotate())
>     inlineStyle->mergeStyleHogeHoge...
> return inlineStyle;
> 
> is clearer, I think.

Done.

[hajimehoshi, 2015-06-11 07:03:34]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2015-06-11 07:03:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1180653005/#ps40001
(title: "tkent's review")

[commit-bot: I haz the power, 2015-06-11 07:03:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180653005/40001

[commit-bot: I haz the power, 2015-06-11 08:09:35]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196924