Build Mojo apps in subdirectories, like application packages.

Build Mojo apps in subdirectories, like application packages.

Build all <foo>.mojo targets in a <foo> sub-directory.
Support resources bundled in mojo_native_application.
Remove mojo_application_package (now redundant).
Update hard-coded paths and simplify URL resolution code.

Remove apps bundled in core_services from Mandoline.apk
(network service, surfaces service, view manager)

This would help NetworkFetcher resolve app locations.
(Android apptests host the build dir on a local server)
(but apptests should instead bundle apps in an apk)

BUG=498020
TEST=Mojo runner and Mandoline still work (as much as they currently do :-/)
R=scottmg@chromium.org,sky@chromium.org

Committed: https://crrev.com/e6439a2c956a2f09f40f10e8394a53437ad269ed
Cr-Commit-Position: refs/heads/master@{#334455}

[msw, 2015-06-12 21:33:10]

Patchset #5 (id:80001) has been deleted

[scottmg, 2015-06-12 22:40:09]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2015-06-12 22:40:10]

https://codereview.chromium.org/1180653002/diff/120001/mandoline/app/android/...
File mandoline/app/android/BUILD.gn (left):

https://codereview.chromium.org/1180653002/diff/120001/mandoline/app/android/...
mandoline/app/android/BUILD.gn:57: "//components/view_manager",
these are gone on purpose?

https://codereview.chromium.org/1180653002/diff/120001/mojo/public/mojo_appli...
File mojo/public/mojo_application.gni (right):

https://codereview.chromium.org/1180653002/diff/120001/mojo/public/mojo_appli...
mojo/public/mojo_application.gni:355: base_target_name = target_name
can this go inside action(target_name) {...}? (or does that change the scoping
somehow?)

[msw, 2015-06-12 22:57:03]

Let me test this some more next week.

https://codereview.chromium.org/1180653002/diff/120001/mandoline/app/android/...
File mandoline/app/android/BUILD.gn (left):

https://codereview.chromium.org/1180653002/diff/120001/mandoline/app/android/...
mandoline/app/android/BUILD.gn:57: "//components/view_manager",
On 2015/06/12 22:40:10, scottmg wrote:
> these are gone on purpose?

Yeah, the view manager, surfaces, and network service are built into
core_services, so these aren't used or needed for Mandoline.

https://codereview.chromium.org/1180653002/diff/120001/mojo/public/mojo_appli...
File mojo/public/mojo_application.gni (right):

https://codereview.chromium.org/1180653002/diff/120001/mojo/public/mojo_appli...
mojo/public/mojo_application.gni:355: base_target_name = target_name
On 2015/06/12 22:40:10, scottmg wrote:
> can this go inside action(target_name) {...}? (or does that change the scoping
> somehow?)

Done.

[msw, 2015-06-15 18:29:11]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-15 18:30:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180653002/160001

[commit-bot: I haz the power, 2015-06-15 19:05:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-15 19:05:33]

Dry run: This issue passed the CQ dry run.

[msw, 2015-06-15 20:15:14]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2015-06-15 20:25:02]

Hey Scotts, please take a look; thanks!

ToT Mandoline crashes on Android for me, this CL doesn't change that:
[ERROR:platform_window_android.cc(173)] Not implemented reached in virtual void
ui::PlatformWindowAndroid::SetBounds(const gfx::Rect&)
E/chromium(16235): [ERROR:platform_window_android.cc(173)] Not implemented
reached in virtual void ui::PlatformWindowAndroid::SetBounds(const gfx::Rect&)
[0615/131535:FATAL:layer_tree_host_impl.cc(2148)] Check failed:
GetRendererCapabilities().using_image. 
#00 0xa200db6b
/data/data/org.chromium.mandoline/app_local_apps/core_services/internal/libcore_services.so+0x0065ab6b
...

I'll look into the crash, but please review in the mean time.

[msw, 2015-06-15 20:40:10]

On 2015/06/15 20:25:02, msw wrote:
> Hey Scotts, please take a look; thanks!
> 
> ToT Mandoline crashes on Android for me, this CL doesn't change that:
> [ERROR:platform_window_android.cc(173)] Not implemented reached in virtual
void
> ui::PlatformWindowAndroid::SetBounds(const gfx::Rect&)
> E/chromium(16235): [ERROR:platform_window_android.cc(173)] Not implemented
> reached in virtual void ui::PlatformWindowAndroid::SetBounds(const gfx::Rect&)
> [0615/131535:FATAL:layer_tree_host_impl.cc(2148)] Check failed:
> GetRendererCapabilities().using_image. 
> #00 0xa200db6b
>
/data/data/org.chromium.mandoline/app_local_apps/core_services/internal/libcore_services.so+0x0065ab6b
> ...
> 
> I'll look into the crash, but please review in the mean time.

Actually, Android doesn't crash with a clean build and John's CL:
https://codereview.chromium.org/1181013010/

[scottmg, 2015-06-15 20:50:00]

lgtm

[sky, 2015-06-15 20:56:22]

LGTM

[msw, 2015-06-15 21:01:33]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2015-06-15 21:02:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180653002/160001

[commit-bot: I haz the power, 2015-06-15 21:10:28]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2015-06-15 21:11:16]

Patchset 8 (id:??) landed as
https://crrev.com/e6439a2c956a2f09f40f10e8394a53437ad269ed
Cr-Commit-Position: refs/heads/master@{#334455}

[msw, 2015-06-15 22:21:55]

A revert of this CL (patchset #8 id:160001) has been created in
https://codereview.chromium.org/1186683008/ by msw@chromium.org.

The reason for reverting is: This makes mojo_runner_unittests fail:
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/...

First failure repro steps and output:
build/android/test_runner.py gtest -s mojo_runner_unittests
--output-directory=/work/chrome-git/src/out/android_Debug
--gtest_filter=ShellTestBaseTest.ConnectBasic

[==========] Running 20 tests from 3 test cases.
[----------] Global test environment set-up.
[----------] 7 tests from ShellTestBaseTest
[ RUN      ] ShellTestBaseTest.ConnectBasic
[ERROR:application_manager.cc(409)] Library not started because library path
'/data/app/org.chromium.native_test-1/lib/arm/tracing/tracing.mojo' does not
exist.
[ERROR:application_manager.cc(409)] Library not started because library path
'/data/data/org.chromium.native_test/app_test_apps/test_app/test_app.mojo' does
not exist.
../../mojo/runner/shell_test_base_unittest.cc:96: Failure
Value of: was_run
  Actual: false
Expected: true
../../mojo/runner/shell_test_base_unittest.cc:97: Failure
Value of: service.encountered_error()
  Actual: true
Expected: false
E  254.854s 6d40  Test terminated after 120 second timeout..