Issue 1180633004: Factor BoxPainter out of RenderDecoratedBox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1180633004: Factor BoxPainter out of RenderDecoratedBox (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Factor BoxPainter out of RenderDecoratedBox This factoring will more code use BoxPainter in the future (in particular, PopupMenu). R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d0e8bf047361bc3ab848aa98a39a611fdd437b6f

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+263 lines, -239 lines)			Patch
M	sky/sdk/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/sdk/lib/framework/painting/box_painter.dart	View	1 chunk	+252 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	2 chunks	+10 lines, -239 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-11 16:37:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d0e8bf047361bc3ab848aa98a39a611fdd437b6f (presubmit successful).