Chromecast: don't try to upload crash immediately.

chromecast/base/chromecast_config_android.cc

Index: chromecast/base/chromecast_config_android.cc
diff --git a/chromecast/android/chromecast_config_android.cc b/chromecast/base/chromecast_config_android.cc
similarity index 54%
rename from chromecast/android/chromecast_config_android.cc
rename to chromecast/base/chromecast_config_android.cc
index d698b70a18b8b16ef3336c80bc21e38a98c045a1..7e09dec0d3e7615189a1607ba7f4d974d99902b3 100644
--- a/chromecast/android/chromecast_config_android.cc
+++ b/chromecast/base/chromecast_config_android.cc
@@ -2,7 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chromecast/android/chromecast_config_android.h"
+#include "chromecast/base/chromecast_config_android.h"
+
+#include "base/android/jni_android.h"
+#include "base/lazy_instance.h"
+#include "jni/ChromecastConfigAndroid_jni.h"
 
 namespace chromecast {
 namespace android {
@@ -17,17 +21,34 @@ ChromecastConfigAndroid* ChromecastConfigAndroid::GetInstance() {
   return g_instance.Pointer();
 }
 
+// static
+bool ChromecastConfigAndroid::RegisterJni(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}
+
 ChromecastConfigAndroid::ChromecastConfigAndroid() {
 }
 
 ChromecastConfigAndroid::~ChromecastConfigAndroid() {
 }
 
+bool ChromecastConfigAndroid::CanSendUsageStats() {
+  JNIEnv* env = base::android::AttachCurrentThread();
+  return Java_ChromecastConfigAndroid_canSendUsageStats(
+      env, base::android::GetApplicationContext());
+}
+
 // Registers a handler to be notified when SendUsageStats is changed.
 void ChromecastConfigAndroid::SetSendUsageStatsChangedCallback(
     const base::Callback<void(bool)>& callback) {
   send_usage_stats_changed_callback_ = callback;
 }
 
+// Called from Java.
+void SetSendUsageStatsEnabled(JNIEnv* env, jclass caller, jboolean enabled) {
+  ChromecastConfigAndroid::GetInstance()->

[byungchul, 2015/06/11 17:15:00]

Why is ChromecastConfigAndroid static in Java and instantiated in c++? Can we
interface CastSettingManager directly from c++?

It looks like, opt-in.stats is necessary in CrashUploader which is initialized
before CastService. Would it make sense make CastSettingsManager a singleton?
ChromecastConfigAndroid has only meaning of that, a singleton interface of
CastSettingsManager. Then, we can avoid initializing CastSettingsManager
multiple times.

[gunsch, 2015/06/12 00:30:30]

We could probably simplify this code more if we upstreamed opt-in.stats and used
that as the source of truth for the UI (e.g. stored it as a Chromium pref rather
than an Android one). I think Stephen is upstreaming it as part of the crash
handling code, and that could be a future cleanup afterwards.

There are other CastSettingsManager instances/listeners besides here and
MediaShellCastReceiverService.

[byungchul, 2015/06/12 05:57:00]

Right, we should use chromecast preference for ATV settings ideally. Can you
leave a TODO for that?

[gunsch, 2015/06/12 16:54:52]

Done. (will upload after addressing other comments, would like your feedback
there)

+      send_usage_stats_changed_callback().Run(enabled);
+}
+
 }  // namespace android
 }  // namespace chromecast