Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tests/standalone/io/platform_test.dart

Issue 1180623006: Revert change to Platform.excutable and add Platform.resolvedExecutable (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/platform_test.dart
diff --git a/tests/standalone/io/platform_test.dart b/tests/standalone/io/platform_test.dart
index 269a4871a4e3a4b884e46c3e3fca89790c5940f9..f713675fb73aff5f0ea5eca64374dbcaf6c63a72 100644
--- a/tests/standalone/io/platform_test.dart
+++ b/tests/standalone/io/platform_test.dart
@@ -25,8 +25,9 @@ test() {
var environment = Platform.environment;
Expect.isTrue(environment is Map<String, String>);
Expect.isTrue(Platform.executable.contains('dart'));
+ Expect.isTrue(Platform.resolvedExecutable.contains('dart'));
Lasse Reichstein Nielsen 2015/06/12 14:12:17 This is making a lot of assumptions. A *lot* - lik
Søren Gjesse 2015/06/15 07:28:15 Sure this is not testing that much. Changed it a b
if (!Platform.isWindows) {
- Expect.isTrue(Platform.executable.startsWith('/'));
+ Expect.isTrue(Platform.resolvedExecutable.startsWith('/'));
} else {
// This assumes that tests (both locally and on the bots) are
// running off a location referred to by a drive letter. If a UNC

Powered by Google App Engine
This is Rietveld 408576698