Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: tests/standalone/io/platform_executable_test.dart

Issue 1180623006: Revert change to Platform.excutable and add Platform.resolvedExecutable (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/platform_executable_test.dart
diff --git a/tests/standalone/io/platform_executable_test.dart b/tests/standalone/io/platform_executable_test.dart
index 3a0e16c73574bca64f6f7512051b34b8f688f957..88e580036c9e7138432086b88ba9189f6f228f00 100644
--- a/tests/standalone/io/platform_executable_test.dart
+++ b/tests/standalone/io/platform_executable_test.dart
@@ -35,7 +35,7 @@ void verify(String exePath, {String altPath}) {
}
var result = processResult.stdout.trim();
- expectEquals(Platform.executable, result);
+ expectEquals(Platform.resolvedExecutable, result);
}
void testDartExecShouldNotBeInCurrentDir() {
@@ -51,20 +51,20 @@ void testShouldSucceedWithEmptyPathEnvironment() {
}
void testShouldSucceedWithSourcePlatformExecutable() {
- verify(Platform.executable);
+ verify(Platform.resolvedExecutable);
}
void testExeSymLinked(Directory dir) {
var dirUri = new Uri.directory(dir.path);
var link = new Link.fromUri(dirUri.resolve('dart_exe_link'));
- link.createSync(Platform.executable);
+ link.createSync(Platform.resolvedExecutable);
verify(link.path);
}
void testPathToDirWithExeSymLinked(Directory dir) {
var dirUri = new Uri.directory(dir.path);
var link = new Link.fromUri(dirUri.resolve('dart_exe_link'));
- link.createSync(Platform.executable);
+ link.createSync(Platform.resolvedExecutable);
verify('dart_exe_link', altPath: dir.path);
}
@@ -75,7 +75,7 @@ void testExeDirSymLinked(Directory dir) {
var linkDirUri = dirUri.resolve('dart_bin_dir_link');
var link = new Link.fromUri(linkDirUri);
- var exeFile = new File(Platform.executable);
+ var exeFile = new File(Platform.resolvedExecutable);
link.createSync(exeFile.parent.path);
@@ -91,7 +91,7 @@ void testPathPointsToSymLinkedSDKPath(Directory dir) {
var linkDirUri = dirUri.resolve('dart_bin_dir_link');
var link = new Link.fromUri(linkDirUri);
- var exeFile = new File(Platform.executable);
+ var exeFile = new File(Platform.resolvedExecutable);
link.createSync(exeFile.parent.path);
@@ -99,7 +99,7 @@ void testPathPointsToSymLinkedSDKPath(Directory dir) {
}
void testPathToSDKDir() {
- var exeFile = new File(Platform.executable);
+ var exeFile = new File(Platform.resolvedExecutable);
var binDirPath = exeFile.parent.path;
verify(platformExeName, altPath: binDirPath);
@@ -115,7 +115,7 @@ void withTempDir(void test(Directory dir)) {
}
String get platformExeName {
- var raw = new Uri.file(Platform.executable);
+ var raw = new Uri.file(Platform.resolvedExecutable);
return raw.pathSegments.last;
}
@@ -123,7 +123,7 @@ String get scriptPath => Platform.script.toFilePath();
void main() {
if (Platform.environment.containsKey(_SCRIPT_KEY)) {
Lasse Reichstein Nielsen 2015/06/12 14:12:17 Docment this. What is _SCRIPT_KEY? What does it me
Søren Gjesse 2015/06/15 07:28:15 Done.
- print(Platform.executable);
+ print(Platform.resolvedExecutable);
return;
}

Powered by Google App Engine
This is Rietveld 408576698