Issue 1180623004: Refactoring: Move MarkupFormatter::totalLength to StyledMarkupAccumulator.cpp as an annonymous func…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1180623004: Refactoring: Move MarkupFormatter::totalLength to StyledMarkupAccumulator.cpp as an annonymous func… (Closed)

Created:
4 years, 10 months ago by hajimehoshi

Modified:
4 years, 10 months ago

Reviewers:
tkent, yosin_UTC9

CC:
blink-reviews, blink-reviews-style_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Refactoring: Move MarkupFormatter::totalLength to StyledMarkupAccumulator.cpp as an annonymous function As totalLength is used only at StyledMarkupAccumulator and totalLength itself has nothing to do with DOM formatting, let's move it to the caller's cpp file. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196946

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -10 lines)			Patch
M	Source/core/editing/MarkupFormatter.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/editing/MarkupFormatter.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/core/editing/StyledMarkupAccumulator.cpp	View	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180623004/1

4 years, 10 months ago (2015-06-11 12:24:08 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-11 13:29:22 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196946

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages