Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: Source/core/dom/NodeRareData.h

Issue 1180603002: Fix the logic that limits the number of frames in a page. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/NodeRareData.h
diff --git a/Source/core/dom/NodeRareData.h b/Source/core/dom/NodeRareData.h
index f19088c088dc674027f483e475ac0af74691f79b..8aad64ffd2fd000ffa36e10efb8ebe0ee32be30c 100644
--- a/Source/core/dom/NodeRareData.h
+++ b/Source/core/dom/NodeRareData.h
@@ -84,6 +84,7 @@ public:
unsigned connectedSubframeCount() const { return m_connectedFrameCount; }
void incrementConnectedSubframeCount(unsigned amount)
{
+ RELEASE_ASSERT_WITH_SECURITY_IMPLICATION((m_connectedFrameCount + amount) < (1 << ConnectedFrameCountBits));
dcheng 2015/06/10 22:08:05 Would it make sense to use maxNumberOfFrames here
Nate Chapin 2015/06/10 22:13:47 I don't feel strongly, though this impl would need
m_connectedFrameCount += amount;
}
void decrementConnectedSubframeCount(unsigned amount)
« no previous file with comments | « no previous file | Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698