Issue 11806004: [Android] Fix import of test_options_parser in run_monkey_test.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11806004: [Android] Fix import of test_options_parser in run_monkey_test.py (Closed)

Created:
7 years, 11 months ago by frankf

Modified:
7 years, 11 months ago

Reviewers:
craigdh, Isaac (away)

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Fix import of test_options_parser in run_monkey_test.py BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175572

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/android/run_monkey_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

BTW we got an external patch (https://codereview.chromium.org/11779040/) for a similar issue in adb_install_apk.py. Any idea ...

7 years, 11 months ago (2013-01-08 18:59:11 UTC) #2

craigdh

lgtm. You should probably add the BUG= issue to the description.

7 years, 11 months ago (2013-01-08 19:01:09 UTC) #3

frankf

On 2013/01/08 18:59:11, Isaac wrote: > BTW we got an external patch (https://codereview.chromium.org/11779040/) for a ...

7 years, 11 months ago (2013-01-08 19:03:41 UTC) #4

Isaac (away)

7 years, 11 months ago (2013-01-08 19:11:10 UTC) #5

Message was sent while issue was closed.

Maybe we need a hook: if you change a python file we delete all pyc files in
repo. 

I had a different issue with pyc files in my refactoring patch. I forgot a $ in
the pylint regex so it matches .py or .pyc files. That meant my tryjob succeeded
on bots without the pyc files, but eventually it started failing and I figured
out issue.

Expand Messages | Collapse Messages