Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: base/process/process_handle_mac.cc

Issue 1180583002: GN updates to build base on iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/process/BUILD.gn ('K') | « base/process/process_handle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/process_handle_mac.cc
diff --git a/base/process/process_handle_mac.cc b/base/process/process_handle_mac.cc
index cbf0bc5c4393fb9d3e0100e21ec3514ac504657b..64a27875024fe4db63fe5d726831527d96ce5eaf 100644
--- a/base/process/process_handle_mac.cc
+++ b/base/process/process_handle_mac.cc
@@ -4,7 +4,10 @@
#include "base/process/process_handle.h"
+#if !defined(OS_IOS)
Nico 2015/06/11 15:37:59 base builds fine for ios in the gyp build. why do
sdefresne 2015/06/11 17:05:17 I suspect you miss some system directory with gn.
Chinmay 2015/06/11 17:44:36 libproc.h is only present on the iPhone Simulator
sdefresne 2015/06/11 17:54:32 I've checked my gyp build and process_handle_mac.c
#include <libproc.h>
+#endif
+
#include <sys/sysctl.h>
#include <sys/types.h>
@@ -25,6 +28,8 @@ ProcessId GetParentProcessId(ProcessHandle process) {
return info.kp_eproc.e_ppid;
}
+#if !defined(OS_IOS)
+
FilePath GetProcessExecutablePath(ProcessHandle process) {
char pathbuf[PROC_PIDPATHINFO_MAXSIZE];
if (!proc_pidpath(process, pathbuf, sizeof(pathbuf)))
@@ -33,4 +38,6 @@ FilePath GetProcessExecutablePath(ProcessHandle process) {
return FilePath(pathbuf);
}
+#endif
+
} // namespace base
« base/process/BUILD.gn ('K') | « base/process/process_handle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698