GN updates to build base on iOS

base/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
 config("base_implementation") {
   defines = [ "BASE_IMPLEMENTATION" ]
+
+  if (is_ios) {
+    # base uses routines deprecated in iOS 8
+    cflags = [ "-Wno-deprecated-declarations" ]

[Nico, 2015/06/11 21:45:04]

This isn't in gyp. Did I understand correctly that you're using a different iOS
SDK version than regular chromium/ios? (I'm pretty sure they use the iOS 8 SDK
too).

Can you fix the deprecation warnings instead of suppressing them?

[Chinmay, 2015/06/11 22:32:16]

Disabling `-Wno-deprecated-declarations` gives me errors regarding deprecation
of methods related to `CFGregorianDate` in `base/third_party/nspr/prtime.cc`.
Both that file and base_paths_mac.mm mentioned below are present in base.gypi as
part of the target sources. prtime.cc in particular does not seem to be part of
a separate target (on which the warning flags might be specifically disabled to
get around this issue). So I am now rather confused about how gyp uses the iOS 8
SDK successfully. Fixing the use of deprecated methods seemed like a yak shaving
exercise given my larger goal of trying to get a build of Sky running on iOS
(which this patch allows me to do). But I understand if you feel like this is
cutting a corner. Let me know if this is a blocker and I can work on avoiding
the use of `CFGregorianDate` and friends.

+  }
 }
 
 if (is_win) {
   # This is in a separate config so the flags can be applied to dependents.
   # ldflags in GN aren't automatically inherited.
   config("base_win_linker_flags") {
     ldflags = [
       "/DELAYLOAD:cfgmgr32.dll",
       "/DELAYLOAD:powrprof.dll",
       "/DELAYLOAD:setupapi.dll",
     ]
   }
 }
 
 source_set("base_paths") {
   sources = [
     "base_paths.cc",
     "base_paths.h",
     "base_paths_android.cc",
     "base_paths_android.h",
     "base_paths_mac.h",
     "base_paths_mac.mm",
     "base_paths_posix.cc",
     "base_paths_posix.h",
     "base_paths_win.cc",
     "base_paths_win.h",
   ]
 
-  if (is_android || is_mac) {
+  if (is_android || is_mac || is_ios) {
     sources -= [ "base_paths_posix.cc" ]
   }
 
   if (is_nacl) {
     sources -= [
       "base_paths.cc",
       "base_paths_posix.cc",
     ]
   }
 
@@ skipping 704 matching lines @@
       "powrprof.lib",
       "setupapi.lib",
     ]
     all_dependent_configs = [ ":base_win_linker_flags" ]
   } else if (!is_nacl) {
     # Non-Windows.
     deps += [ "//third_party/libevent" ]
   }
 
   # Mac.
-  if (is_mac) {
+  if (is_mac || is_ios) {
+    # Common Desktop / iOS excludes
     sources -= [
       "native_library_posix.cc",
       "strings/sys_string_conversions_posix.cc",
       "threading/platform_thread_internal_posix.cc",
     ]
+
+    if (is_ios) {
+      sources -= [
+        "files/file_path_watcher_fsevents.cc",
+        "files/file_path_watcher_fsevents.h",
+      ]
+    }
   } else {
     # Non-Mac.
     sources -= [
       "files/file_path_watcher_fsevents.cc",
       "files/file_path_watcher_fsevents.h",
       "files/file_path_watcher_kqueue.cc",
       "files/file_path_watcher_kqueue.h",
     ]
   }
 
@@ skipping 24 matching lines @@
     ]
 
     if (!is_android) {
       sources -= [
         "linux_util.cc",
         "linux_util.h",
       ]
     }
   }
 
+  # iOS
+  if (is_ios) {
+    set_sources_assignment_filter([])
+
+    sources += [

[Nico, 2015/06/12 00:42:08]

Do you want to add atomicops_internals_mac.h too? (The gyp files do this)

+      "base_paths_mac.h",
+      "base_paths_mac.mm",

[Nico, 2015/06/11 21:45:04]

I still don't see this included in the gyp files

+      "files/file_util_mac.mm",
+      "mac/bundle_locations.h",
+      "mac/bundle_locations.mm",
+      "mac/foundation_util.h",
+      "mac/foundation_util.mm",
+      "mac/mach_logging.cc",
+      "mac/mach_logging.h",

[Nico, 2015/06/12 00:42:08]

The gyp file also adds objc_property_releaser.h/mm

…in general, the section you linked to lists several more files that you don't
list here.

+      "mac/scoped_mach_port.cc",
+      "mac/scoped_mach_port.h",
+      "mac/scoped_nsautorelease_pool.h",
+      "mac/scoped_nsautorelease_pool.mm",
+      "message_loop/message_pump_mac.h",
+      "message_loop/message_pump_mac.mm",
+      "strings/sys_string_conversions_mac.mm",
+      "threading/platform_thread_mac.mm",
+      "time/time_mac.cc",
+    ]
+
+    set_sources_assignment_filter(sources_assignment_filter)
+  }
+
   if (!use_glib) {
     sources -= [
       "message_loop/message_pump_glib.cc",
       "message_loop/message_pump_glib.h",
     ]
   }
 
   configs += [ "//build/config/compiler:wexit_time_destructors" ]
   if (is_android && !is_debug) {
     configs -= [ "//build/config/compiler:optimize" ]
@@ skipping 506 matching lines @@
     apk_deps = [
       ":base_java",
       ":base_java_unittest_support",
     ]
     isolate_file = "base_unittests.isolate"
   }
 
   if (is_ios) {
     sources -= [
       "process/memory_unittest.cc",
-      "process/memory_unittest_mac.h",
-      "process/memory_unittest_mac.mm",
       "process/process_unittest.cc",
       "process/process_util_unittest.cc",
     ]
 
     # Pull in specific Mac files for iOS (which have been filtered out by file
     # name rules).
     set_sources_assignment_filter([])
     sources += [
       "mac/bind_objc_block_unittest.mm",
       "mac/foundation_util_unittest.mm",
@@ skipping 156 matching lines @@
 
   # GYP: //base.gyp:base_java_unittest_support
   android_library("base_java_unittest_support") {
     deps = [
       ":base_java",
     ]
     java_files =
         [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
   }
 }