Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: components/view_manager/native_viewport/BUILD.gn

Issue 1180573004: android: Introduce a ui::PlatformWindow implementation for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/view_manager/native_viewport/BUILD.gn
diff --git a/components/view_manager/native_viewport/BUILD.gn b/components/view_manager/native_viewport/BUILD.gn
index ae0014cbc4be741b4c313db41b473432d2b3bacd..a80c3e3460816ff219d80ca4b2ec1b5366b5390a 100644
--- a/components/view_manager/native_viewport/BUILD.gn
+++ b/components/view_manager/native_viewport/BUILD.gn
@@ -9,13 +9,10 @@ source_set("native_viewport") {
"onscreen_context_provider.cc",
"onscreen_context_provider.h",
"platform_viewport.h",
- "platform_viewport_android.cc",
- "platform_viewport_android.h",
+ "platform_viewport_common.cc",
"platform_viewport_headless.cc",
"platform_viewport_headless.h",
"platform_viewport_stub.cc",
- "platform_viewport_win.cc",
- "platform_viewport_x11.cc",
]
if (!is_ios) {
@@ -41,13 +38,14 @@ source_set("native_viewport") {
]
if (is_android) {
- deps += [ "//components/view_manager:jni_headers" ]
+ deps += [
+ "//ui/platform_window/android",
Ben Goodger (Google) 2015/06/11 17:37:09 I'm wondering if it's possible for these deps to c
sadrul 2015/06/11 21:09:54 Introduced a new 'platform_impls' target in there
+ "//ui/platform_window/android:jni_headers",
+ ]
}
if (use_x11) {
deps += [ "//ui/platform_window/x11" ]
- } else {
- sources -= [ "platform_viewport_x11.cc" ]
}
if (is_win) {

Powered by Google App Engine
This is Rietveld 408576698