android: Introduce a ui::PlatformWindow implementation for android.

android: Introduce a ui::PlatformWindow implementation for android.

This change introduces a ui::PlatformWindow implementation for android, and uses
that from view_manager. The implementation of PlatformWindowAndroid is copied over
from PlatformViewportAndroid. The various PlatformViewport implementations are
merged into a single PlatformViewportCommon implementation, that uses the common
ui::PlaformWindow abstraction for managing the windows.

BUG=487881
Committed: https://crrev.com/870d6cf7d409b5e7dae82c98bfaeaa5137a652d9
Cr-Commit-Position: refs/heads/master@{#334262}

Committed: https://crrev.com/1218a59ca7ab3df47de0a6103842d1415360e4a8
Cr-Commit-Position: refs/heads/master@{#334359}

[sadrul, 2015-06-11 16:05:35]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org

[sadrul, 2015-06-11 16:05:36]

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
File components/view_manager/native_viewport/platform_viewport_common.cc
(right):

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
components/view_manager/native_viewport/platform_viewport_common.cc:69: #endif
It's a bit ugly, but since NativeViewport will be going away soon anyway, I
thought this would be tolerable?

[Ben Goodger (Google), 2015-06-11 17:37:09]

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
File components/view_manager/native_viewport/BUILD.gn (right):

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
components/view_manager/native_viewport/BUILD.gn:42:
"//ui/platform_window/android",
I'm wondering if it's possible for these deps to come transitively via
platform_window, using public_deps

... specifically it'd be nice for any code that wants to depend on
platform_window to just be able to depend on //ui/platform_window and have that
haul in all the right stuff regardless of platform.

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
File components/view_manager/native_viewport/platform_viewport_common.cc
(right):

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
components/view_manager/native_viewport/platform_viewport_common.cc:43: public
ui::PlatformWindowDelegate {
nit: indent

[sadrul, 2015-06-11 21:06:49]

Patchset #5 (id:80001) has been deleted

[sadrul, 2015-06-11 21:07:25]

Patchset #5 (id:100001) has been deleted

[sadrul, 2015-06-11 21:09:54]

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
File components/view_manager/native_viewport/BUILD.gn (right):

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
components/view_manager/native_viewport/BUILD.gn:42:
"//ui/platform_window/android",
On 2015/06/11 17:37:09, Ben Goodger (Google) wrote:
> I'm wondering if it's possible for these deps to come transitively via
> platform_window, using public_deps
> 
> ... specifically it'd be nice for any code that wants to depend on
> platform_window to just be able to depend on //ui/platform_window and have
that
> haul in all the right stuff regardless of platform.

Introduced a new 'platform_impls' target in there for that. Done.
(platform_window itself probably shouldn't pull in a default impl, since the
ozone platforms provide their own implementations for platform-window).

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
File components/view_manager/native_viewport/platform_viewport_common.cc
(right):

https://codereview.chromium.org/1180573004/diff/60001/components/view_manager...
components/view_manager/native_viewport/platform_viewport_common.cc:43: public
ui::PlatformWindowDelegate {
On 2015/06/11 17:37:09, Ben Goodger (Google) wrote:
> nit: indent

Done.

[Ben Goodger (Google), 2015-06-12 17:50:21]

lgtm

[sadrul, 2015-06-12 21:18:10]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2015-06-12 21:20:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180573004/120001

[commit-bot: I haz the power, 2015-06-12 22:37:57]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-06-12 22:38:51]

Patchset 5 (id:??) landed as
https://crrev.com/870d6cf7d409b5e7dae82c98bfaeaa5137a652d9
Cr-Commit-Position: refs/heads/master@{#334262}

[skobes, 2015-06-12 23:39:50]

A revert of this CL (patchset #5 id:120001) has been created in
https://codereview.chromium.org/1184913004/ by skobes@chromium.org.

The reason for reverting is: Breaks Win GN bots:

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/2751

e:\b\build\slave\win_x64_gn\build\src\components\view_manager\native_viewport\platform_viewport_common.cc(64)
: error C3861: 'platform_window_reset': identifier not found
e:\b\build\slave\win_x64_gn\build\src\components\view_manager\native_viewport\platform_viewport_common.cc(64)
: error C2664: 'ui::WinWindow::WinWindow(const ui::WinWindow &)' : cannot
convert argument 1 from 'native_viewport::PlatformViewportCommon *const ' to
'const ui::WinWindow &'
        Reason: cannot convert from 'native_viewport::PlatformViewportCommon
*const ' to 'const ui::WinWindow'
        No constructor could take the source type, or constructor overload
resolution was ambiguous.

[sadrul, 2015-06-15 01:51:57]

Patchset #6 (id:140001) has been deleted

[sadrul, 2015-06-15 02:30:59]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2015-06-15 02:31:00]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1180573004/#ps160001
(title: "fix-win-gn")

[commit-bot: I haz the power, 2015-06-15 02:31:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180573004/160001

[commit-bot: I haz the power, 2015-06-15 08:12:36]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2015-06-15 08:14:35]

Patchset 6 (id:??) landed as
https://crrev.com/1218a59ca7ab3df47de0a6103842d1415360e4a8
Cr-Commit-Position: refs/heads/master@{#334359}