Add option to dump line box tree when dumping layout tree.

Add option to dump line box tree when dumping layout tree.

Sample output: http://pastebin.com/cP8qnF0B

This is turned off by default; in a separate CL, I'm going to add a
--dump-line-box-trees option to content_shell to turn it on:

https://codereview.chromium.org/1185563002/

R=leviw@chromium.org,eae@chromium.org
BUG=499644
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197135

[szager1, 2015-06-10 21:44:14]

szager@chromium.org changed reviewers:
+ esprehn@chromium.org, pdr@chromium.org

[szager1, 2015-06-10 21:44:14]

pdr@ and esprehn@ for OWNERS

[esprehn, 2015-06-10 22:07:13]

https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
File Source/core/layout/LayoutTreeAsText.cpp (right):

https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutTreeAsText.cpp:409: static void
writeInlineBox(TextStream& ts, const InlineBox *box, int indent)
* goes with the type, not the var, also I think you want to pass a reference,

https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutTreeAsText.cpp:420: static void
writeInlineTextBox(TextStream& ts, const InlineTextBox *textBox, int indent)
ditto

https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutTreeAsText.cpp:431: static void
writeInlineFlowBox(TextStream& ts, const InlineFlowBox *rootBox, int indent)
ditto

https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutTreeAsText.cpp:450: for (const InlineFlowBox *rootBox =
o.firstLineBox(); rootBox; rootBox = rootBox->nextLineBox()) {
* with the type.

[szager1, 2015-06-10 23:30:33]

https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
File Source/core/layout/LayoutTreeAsText.cpp (right):

https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutTreeAsText.cpp:409: static void
writeInlineBox(TextStream& ts, const InlineBox *box, int indent)
On 2015/06/10 22:07:13, esprehn wrote:
> * goes with the type, not the var, also I think you want to pass a reference,

I fixed all the '*' placements.  Why pass a reference?

[leviw_travelin_and_unemployed, 2015-06-10 23:37:11]

On 2015/06/10 at 23:30:33, szager wrote:
>
https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
> File Source/core/layout/LayoutTreeAsText.cpp (right):
> 
>
https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
> Source/core/layout/LayoutTreeAsText.cpp:409: static void
writeInlineBox(TextStream& ts, const InlineBox *box, int indent)
> On 2015/06/10 22:07:13, esprehn wrote:
> > * goes with the type, not the var, also I think you want to pass a
reference,
> 
> I fixed all the '*' placements.  Why pass a reference?

The contract should be that you don't call it with a nullptr. Using a reference
indicates the value shouldn't be null.

[szager1, 2015-06-12 00:00:19]

On 2015/06/10 23:37:11, leviw wrote:
> On 2015/06/10 at 23:30:33, szager wrote:
> >
>
https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
> > File Source/core/layout/LayoutTreeAsText.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/Layo...
> > Source/core/layout/LayoutTreeAsText.cpp:409: static void
> writeInlineBox(TextStream& ts, const InlineBox *box, int indent)
> > On 2015/06/10 22:07:13, esprehn wrote:
> > > * goes with the type, not the var, also I think you want to pass a
> reference,
> > 
> > I fixed all the '*' placements.  Why pass a reference?
> 
> The contract should be that you don't call it with a nullptr. Using a
reference
> indicates the value shouldn't be null.

OK, done, PTAL.

[leviw_travelin_and_unemployed, 2015-06-12 00:05:04]

Can you file a bug so we have the context for why you're doing this (intention
to enable layout tests to output this)? Then you can fill in that sad "BUG="
line ;)

LGTM.

[szager1, 2015-06-12 01:05:10]

On 2015/06/12 00:05:04, leviw wrote:
> Can you file a bug so we have the context for why you're doing this (intention
> to enable layout tests to output this)? Then you can fill in that sad "BUG="
> line ;)
> 
> LGTM.

done

[szager1, 2015-06-12 01:05:16]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2015-06-12 01:05:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180573003/60001

[commit-bot: I haz the power, 2015-06-12 01:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 01:12:09]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[szager1, 2015-06-12 01:58:25]

ping pdr@ and esprehn@ for OWNERS lgtm.

[Mike West, 2015-06-12 07:23:04]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-06-12 07:23:05]

If Levi's happy, then public/web and Source/web LGTM.

[Mike West, 2015-06-12 07:24:40]

Would you mind adding a link to the Chromium-side patch here as well?
https://codereview.chromium.org/1162443006 is an example of how I like to
structure that kind of thing to make the entire patch clear from the git log.

[szager1, 2015-06-15 18:21:04]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2015-06-15 18:21:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1180573003/60001

[commit-bot: I haz the power, 2015-06-15 19:30:36]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197135