Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 1180573003: Add option to dump line box tree when dumping layout tree. (Closed)

Created:
4 years, 10 months ago by szager1
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add option to dump line box tree when dumping layout tree. Sample output: http://pastebin.com/cP8qnF0B This is turned off by default; in a separate CL, I'm going to add a --dump-line-box-trees option to content_shell to turn it on: https://codereview.chromium.org/1185563002/ R=leviw@chromium.org,eae@chromium.org BUG=499644 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197135

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 5

Patch Set 3 : nits #

Patch Set 4 : pointers->references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -3 lines) Patch
M Source/core/layout/LayoutTreeAsText.h View 3 chunks +5 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutTreeAsText.cpp View 1 2 3 4 chunks +52 lines, -0 lines 0 comments Download
M Source/platform/text/TextStream.h View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/platform/text/TextStream.cpp View 2 chunks +25 lines, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M public/web/WebFrame.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (5 generated)
szager1
4 years, 10 months ago (2015-06-10 21:41:17 UTC) #1
szager1
pdr@ and esprehn@ for OWNERS
4 years, 10 months ago (2015-06-10 21:44:14 UTC) #3
esprehn
https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/LayoutTreeAsText.cpp File Source/core/layout/LayoutTreeAsText.cpp (right): https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/LayoutTreeAsText.cpp#newcode409 Source/core/layout/LayoutTreeAsText.cpp:409: static void writeInlineBox(TextStream& ts, const InlineBox *box, int indent) ...
4 years, 10 months ago (2015-06-10 22:07:13 UTC) #4
szager1
https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/LayoutTreeAsText.cpp File Source/core/layout/LayoutTreeAsText.cpp (right): https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/LayoutTreeAsText.cpp#newcode409 Source/core/layout/LayoutTreeAsText.cpp:409: static void writeInlineBox(TextStream& ts, const InlineBox *box, int indent) ...
4 years, 10 months ago (2015-06-10 23:30:33 UTC) #5
leviw_travelin_and_unemployed
On 2015/06/10 at 23:30:33, szager wrote: > https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/LayoutTreeAsText.cpp > File Source/core/layout/LayoutTreeAsText.cpp (right): > > https://codereview.chromium.org/1180573003/diff/20001/Source/core/layout/LayoutTreeAsText.cpp#newcode409 ...
4 years, 10 months ago (2015-06-10 23:37:11 UTC) #6
szager1
On 2015/06/10 23:37:11, leviw wrote: > On 2015/06/10 at 23:30:33, szager wrote: > > > ...
4 years, 10 months ago (2015-06-12 00:00:19 UTC) #7
leviw_travelin_and_unemployed
Can you file a bug so we have the context for why you're doing this ...
4 years, 10 months ago (2015-06-12 00:05:04 UTC) #8
szager1
On 2015/06/12 00:05:04, leviw wrote: > Can you file a bug so we have the ...
4 years, 10 months ago (2015-06-12 01:05:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180573003/60001
4 years, 10 months ago (2015-06-12 01:05:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/35215)
4 years, 10 months ago (2015-06-12 01:12:09 UTC) #13
szager1
ping pdr@ and esprehn@ for OWNERS lgtm.
4 years, 10 months ago (2015-06-12 01:58:25 UTC) #14
Mike West
If Levi's happy, then public/web and Source/web LGTM.
4 years, 10 months ago (2015-06-12 07:23:05 UTC) #16
Mike West
Would you mind adding a link to the Chromium-side patch here as well? https://codereview.chromium.org/1162443006 is ...
4 years, 10 months ago (2015-06-12 07:24:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180573003/60001
4 years, 10 months ago (2015-06-15 18:21:35 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 19:30:36 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197135

Powered by Google App Engine
This is Rietveld 408576698