Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: LayoutTests/inspector/tracing/timeline-receive-response-event.html

Issue 1180493002: Timeline: fix flakeyness of timeline-receive-response-event-expected.txt (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/FlakyTests ('k') | LayoutTests/inspector/tracing/timeline-receive-response-event-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/inspector/tracing/timeline-receive-response-event.html
diff --git a/LayoutTests/inspector/tracing/timeline-receive-response-event.html b/LayoutTests/inspector/tracing/timeline-receive-response-event.html
index 6eceab6b02bb0b81fc08cb2a9e7f78693b9a5359..eb6b1a32c06c42aeeaee3b25399510abe1c71564 100644
--- a/LayoutTests/inspector/tracing/timeline-receive-response-event.html
+++ b/LayoutTests/inspector/tracing/timeline-receive-response-event.html
@@ -10,7 +10,8 @@ function performActions(callback)
image.onload = bar;
image.src = "resources/anImage.png";
- function bar() {
+ function bar()
+ {
var image = new Image();
image.onload = function(event) { callback(); } // do not pass event argument to the callback.
image.src = "resources/anotherImage.png";
@@ -29,19 +30,19 @@ function test()
{
var record = presentationRecord.record();
prefix = prefix || "";
- // Here and below: pretend coalesced record are just not there, as coalescation is time dependent and, hence, not stable.
+ // Ignore stray paint & rendering events for better stability.
var categoryName = WebInspector.TimelineUIUtils.categoryForRecord(record).name;
- if (categoryName !== "loading" && categoryName !== "scripting")
+ if (categoryName !== "loading" && categoryName !== "scripting")
return;
var childPrefix = prefix;
+ // Here and below: pretend coalesced record are just not there, as coalescation is time dependent and, hence, not stable.
// Filter out InjectedScript function call because they happen out of sync.
if (!presentationRecord.coalesced()
&& record.type() !== "GCEvent"
- && (record.type() !== "FunctionCall" || record.data().scriptName !== "InjectedScript")) {
+ && (record.type() !== "FunctionCall" || record.data().scriptName)) {
InspectorTest.addResult(prefix + record.type());
childPrefix = childPrefix + " ";
}
- // Ignore stray paint & rendering events for better stability.
if (presentationRecord.presentationChildren()) {
for (var i = 0; i < presentationRecord.presentationChildren().length; ++i)
dumpFormattedRecord(presentationRecord.presentationChildren()[i], childPrefix);
« no previous file with comments | « LayoutTests/FlakyTests ('k') | LayoutTests/inspector/tracing/timeline-receive-response-event-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698