Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: extensions/browser/extensions_browser_client.h

Issue 118043003: Fix app_shell shutdown crash due to BrowserContextKeyedServices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ScopedFactoryForTest (shutdown_crash) Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_system_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extensions_browser_client.h
diff --git a/extensions/browser/extensions_browser_client.h b/extensions/browser/extensions_browser_client.h
index c93b629995a3519022aef34292b88b4592aa69d3..306515fd9b37a347909574e52b64fe7c325a3fd6 100644
--- a/extensions/browser/extensions_browser_client.h
+++ b/extensions/browser/extensions_browser_client.h
@@ -5,8 +5,11 @@
#ifndef EXTENSIONS_BROWSER_EXTENSIONS_BROWSER_CLIENT_H_
#define EXTENSIONS_BROWSER_EXTENSIONS_BROWSER_CLIENT_H_
+#include <vector>
+
#include "base/memory/scoped_ptr.h"
+class BrowserContextKeyedServiceFactory;
class CommandLine;
class PrefService;
@@ -18,6 +21,7 @@ class JavaScriptDialogManager;
namespace extensions {
class AppSorting;
+class ExtensionSystem;
// Interface to allow the extensions module to make browser-process-specific
// queries of the embedder. Should be Set() once in the browser process.
@@ -87,6 +91,14 @@ class ExtensionsBrowserClient {
// does not support JavaScript dialogs.
virtual content::JavaScriptDialogManager* GetJavaScriptDialogManager() = 0;
+ // Returns the dependencies of ExtensionSystem. May return an empty list.
+ virtual std::vector<BrowserContextKeyedServiceFactory*>
+ GetExtensionSystemDependencies() = 0;
+
+ // Creates a new ExtensionSystem for |context|.
+ virtual ExtensionSystem* CreateExtensionSystem(
+ content::BrowserContext* context) = 0;
+
// Returns the single instance of |this|.
static ExtensionsBrowserClient* Get();
« no previous file with comments | « chrome/browser/extensions/extension_system_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698