apps/shell/shell_extensions_browser_client.h - Issue 118043003: Fix app_shell shutdown crash due to BrowserContextKeyedServices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/shell/shell_extensions_browser_client.h

Issue 118043003: Fix app_shell shutdown crash due to BrowserContextKeyedServices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: delegate out ExtensionSystem creation (shutdown_crash) Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: apps/shell/shell_extensions_browser_client.h

diff --git a/apps/shell/shell_extensions_browser_client.h b/apps/shell/shell_extensions_browser_client.h

index 13998a1cad04ac9666c26bbe85ba7672af9de280..eb6327c347919c2052e3a22162245015be3d6a8a 100644

--- a/apps/shell/shell_extensions_browser_client.h

+++ b/apps/shell/shell_extensions_browser_client.h

@@ -45,6 +45,10 @@ class ShellExtensionsBrowserClient

virtual bool IsRunningInForcedAppMode() OVERRIDE;

virtual content::JavaScriptDialogManager* GetJavaScriptDialogManager()

OVERRIDE;

+ virtual std::vector<BrowserContextKeyedServiceFactory*>

+ GetExtensionSystemDependencies() OVERRIDE;

+ virtual extensions::ExtensionSystem* CreateExtensionSystem(

+ content::BrowserContext* context) OVERRIDE;

private:

// The single BrowserContext for app_shell. Not owned.