chrome/browser/extensions/chrome_extensions_browser_client.h - Issue 118043003: Fix app_shell shutdown crash due to BrowserContextKeyedServices

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/chrome_extensions_browser_client.h

Issue 118043003: Fix app_shell shutdown crash due to BrowserContextKeyedServices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ScopedFactoryForTest (shutdown_crash) Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_	5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_

6 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_	6 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "base/lazy_instance.h"	10 #include "base/lazy_instance.h"

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 content::BrowserContext* context) OVERRIDE;	48 content::BrowserContext* context) OVERRIDE;

49 virtual bool DeferLoadingBackgroundHosts(	49 virtual bool DeferLoadingBackgroundHosts(

50 content::BrowserContext* context) const OVERRIDE;	50 content::BrowserContext* context) const OVERRIDE;

51 virtual bool IsBackgroundPageAllowed(	51 virtual bool IsBackgroundPageAllowed(

52 content::BrowserContext* context) const OVERRIDE;	52 content::BrowserContext* context) const OVERRIDE;

53 virtual bool DidVersionUpdate(content::BrowserContext* context) OVERRIDE;	53 virtual bool DidVersionUpdate(content::BrowserContext* context) OVERRIDE;

54 virtual scoped_ptr<AppSorting> CreateAppSorting() OVERRIDE;	54 virtual scoped_ptr<AppSorting> CreateAppSorting() OVERRIDE;

55 virtual bool IsRunningInForcedAppMode() OVERRIDE;	55 virtual bool IsRunningInForcedAppMode() OVERRIDE;

56 virtual content::JavaScriptDialogManager* GetJavaScriptDialogManager()	56 virtual content::JavaScriptDialogManager* GetJavaScriptDialogManager()

57 OVERRIDE;	57 OVERRIDE;

	58 virtual std::vector<BrowserContextKeyedServiceFactory*>

	59 GetExtensionSystemDependencies() OVERRIDE;

	60 virtual ExtensionSystem* CreateExtensionSystem(

	61 content::BrowserContext* context) OVERRIDE;

58	62

59 private:	63 private:

60 friend struct base::DefaultLazyInstanceTraits<ChromeExtensionsBrowserClient>;	64 friend struct base::DefaultLazyInstanceTraits<ChromeExtensionsBrowserClient>;

61	65

62 // Observer for Chrome-specific notifications.	66 // Observer for Chrome-specific notifications.

63 ChromeNotificationObserver notification_observer_;	67 ChromeNotificationObserver notification_observer_;

64	68

65 DISALLOW_COPY_AND_ASSIGN(ChromeExtensionsBrowserClient);	69 DISALLOW_COPY_AND_ASSIGN(ChromeExtensionsBrowserClient);

66 };	70 };

67	71

68 } // namespace extensions	72 } // namespace extensions

69	73

70 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_	74 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSIONS_BROWSER_CLIENT_H_

OLD	NEW