Fix app_shell shutdown crash due to BrowserContextKeyedServices

chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "chrome/browser/extensions/event_names.h"
 #include "chrome/browser/extensions/extension_apitest.h"
@@ skipping 19 matching lines @@
 using ::testing::Return;
 using fileapi::FileSystemURL;
 using sync_file_system::MockRemoteFileSyncService;
 using sync_file_system::RemoteFileSyncService;
 using sync_file_system::SyncFileSystemServiceFactory;
 
 namespace {
 
 class SyncFileSystemApiTest : public ExtensionApiTest {
  public:
-  SyncFileSystemApiTest() {}
+  SyncFileSystemApiTest()
+      : mock_remote_service_(NULL), real_default_quota_(0) {}
 
   virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
-    mock_remote_service_ = new ::testing::NiceMock<MockRemoteFileSyncService>;
-    SyncFileSystemServiceFactory::GetInstance()->set_mock_remote_file_service(
-        scoped_ptr<RemoteFileSyncService>(mock_remote_service_));
-
     ExtensionApiTest::SetUpInProcessBrowserTestFixture();
     // TODO(calvinlo): Update test code after default quota is made const
     // (http://crbug.com/155488).
     real_default_quota_ = quota::QuotaManager::kSyncableStorageDefaultHostQuota;
     quota::QuotaManager::kSyncableStorageDefaultHostQuota = 123456;
   }
 
   virtual void TearDownInProcessBrowserTestFixture() OVERRIDE {
     quota::QuotaManager::kSyncableStorageDefaultHostQuota = real_default_quota_;
     ExtensionApiTest::TearDownInProcessBrowserTestFixture();
   }
 
+  virtual void SetUpOnMainThread() OVERRIDE {
+    // Must happen after the browser process is created because instantiating
+    // the factory will instantiate ExtensionSystemFactory which depends on
+    // ExtensionsBrowserClient setup in BrowserProcessImpl.
+    mock_remote_service_ = new ::testing::NiceMock<MockRemoteFileSyncService>;
+    SyncFileSystemServiceFactory::GetInstance()->set_mock_remote_file_service(
+        scoped_ptr<RemoteFileSyncService>(mock_remote_service_));
+    ExtensionApiTest::SetUpOnMainThread();
+  }
+
   ::testing::NiceMock<MockRemoteFileSyncService>* mock_remote_service() {
     return mock_remote_service_;
   }
 
  private:
   ::testing::NiceMock<MockRemoteFileSyncService>* mock_remote_service_;
   int64 real_default_quota_;
 };
 
 ACTION_P(NotifyOkStateAndCallback, mock_remote_service) {
@@ skipping 127 matching lines @@
   ASSERT_TRUE(RunPlatformAppTest("sync_file_system/conflict_resolution_policy"))
       << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(SyncFileSystemApiTest, GetServiceStatus) {
   mock_remote_service()->SetServiceState(
       sync_file_system::REMOTE_SERVICE_AUTHENTICATION_REQUIRED);
   ASSERT_TRUE(RunPlatformAppTest("sync_file_system/get_service_status"))
       << message_;
 }