Fix app_shell shutdown crash due to BrowserContextKeyedServices

apps/shell/shell_extensions_browser_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell/shell_extensions_browser_client.h"
 
 #include "apps/shell/shell_app_sorting.h"
+#include "apps/shell/shell_extension_system.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/pref_service_factory.h"
 #include "base/prefs/testing_pref_store.h"
 #include "chrome/browser/extensions/extension_prefs.h"
+#include "chrome/browser/extensions/extension_prefs_factory.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "components/user_prefs/user_prefs.h"
 #include "extensions/browser/app_sorting.h"
 
 using content::BrowserContext;
 
+namespace extensions {
 namespace {
 
 // See chrome::RegisterProfilePrefs() in chrome/browser/prefs/browser_prefs.cc
 void RegisterPrefs(user_prefs::PrefRegistrySyncable* registry) {
-  extensions::ExtensionPrefs::RegisterProfilePrefs(registry);
+  ExtensionPrefs::RegisterProfilePrefs(registry);
 }
 
 }  // namespace
 
-namespace apps {
 
 ShellExtensionsBrowserClient::ShellExtensionsBrowserClient(
     BrowserContext* context)
     : browser_context_(context) {
   // Set up the preferences service.
   base::PrefServiceFactory factory;
   factory.set_user_prefs(new TestingPrefStore);
   factory.set_extension_prefs(new TestingPrefStore);
   // app_shell should not require syncable preferences, but for now we need to
   // recycle some of the RegisterProfilePrefs() code in Chrome.
@@ skipping 56 matching lines @@
 bool ShellExtensionsBrowserClient::IsBackgroundPageAllowed(
     BrowserContext* context) const {
   return true;
 }
 
 bool ShellExtensionsBrowserClient::DidVersionUpdate(BrowserContext* context) {
   // TODO(jamescook): We might want to tell extensions when app_shell updates.
   return false;
 }
 
-scoped_ptr<extensions::AppSorting>
-ShellExtensionsBrowserClient::CreateAppSorting() {
-  return scoped_ptr<extensions::AppSorting>(new ShellAppSorting).Pass();
+scoped_ptr<AppSorting> ShellExtensionsBrowserClient::CreateAppSorting() {
+  return scoped_ptr<AppSorting>(new apps::ShellAppSorting).Pass();
 }
 
 bool ShellExtensionsBrowserClient::IsRunningInForcedAppMode() {
   return false;
 }
 
 content::JavaScriptDialogManager*
 ShellExtensionsBrowserClient::GetJavaScriptDialogManager() {
   // TODO(jamescook): Create a JavaScriptDialogManager or reuse the one from
   // content_shell.
   NOTREACHED();
   return NULL;
 }
 
-}  // namespace apps
+std::vector<BrowserContextKeyedServiceFactory*>
+ShellExtensionsBrowserClient::GetExtensionSystemDependencies() {
+  std::vector<BrowserContextKeyedServiceFactory*> depends_on;
+  depends_on.push_back(ExtensionPrefsFactory::GetInstance());
+  return depends_on;
+}
+
+ExtensionSystem* ShellExtensionsBrowserClient::CreateExtensionSystem(
+    BrowserContext* context) {
+  return new ShellExtensionSystem(context);
+}
+
+}  // namespace extensions