Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Side by Side Diff: apps/shell/shell_browser_main_parts.h

Issue 118043003: Fix app_shell shutdown crash due to BrowserContextKeyedServices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ScopedFactoryForTest (shutdown_crash) Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « apps/shell/shell_browser_context.cc ('k') | apps/shell/shell_browser_main_parts.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef APPS_SHELL_SHELL_BROWSER_MAIN_PARTS_H_ 5 #ifndef APPS_SHELL_SHELL_BROWSER_MAIN_PARTS_H_
6 #define APPS_SHELL_SHELL_BROWSER_MAIN_PARTS_H_ 6 #define APPS_SHELL_SHELL_BROWSER_MAIN_PARTS_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "content/public/browser/browser_main_parts.h" 11 #include "content/public/browser/browser_main_parts.h"
12 #include "ui/aura/root_window_observer.h" 12 #include "ui/aura/root_window_observer.h"
13 13
14 namespace aura { 14 namespace aura {
15 class TestScreen; 15 class TestScreen;
16 } 16 }
17 17
18 namespace content { 18 namespace content {
19 class ShellBrowserContext; 19 class ShellBrowserContext;
20 struct MainFunctionParams; 20 struct MainFunctionParams;
21 } 21 }
22 22
23 namespace extensions { 23 namespace extensions {
24 class ShellExtensionsBrowserClient;
24 class ShellExtensionSystem; 25 class ShellExtensionSystem;
25 } 26 }
26 27
27 namespace wm { 28 namespace wm {
28 class WMTestHelper; 29 class WMTestHelper;
29 } 30 }
30 31
31 namespace apps { 32 namespace apps {
32 33
33 class ShellBrowserContext; 34 class ShellBrowserContext;
34 class ShellExtensionsBrowserClient;
35 class ShellExtensionsClient; 35 class ShellExtensionsClient;
36 36
37 // Handles initialization of AppShell. 37 // Handles initialization of AppShell.
38 class ShellBrowserMainParts : public content::BrowserMainParts, 38 class ShellBrowserMainParts : public content::BrowserMainParts,
39 public aura::RootWindowObserver { 39 public aura::RootWindowObserver {
40 public: 40 public:
41 explicit ShellBrowserMainParts( 41 explicit ShellBrowserMainParts(
42 const content::MainFunctionParams& parameters); 42 const content::MainFunctionParams& parameters);
43 virtual ~ShellBrowserMainParts(); 43 virtual ~ShellBrowserMainParts();
44 44
(...skipping 19 matching lines...) Expand all
64 void CreateRootWindow(); 64 void CreateRootWindow();
65 65
66 // Closes and destroys the root window hosting the app. 66 // Closes and destroys the root window hosting the app.
67 void DestroyRootWindow(); 67 void DestroyRootWindow();
68 68
69 // Creates and initializes the ExtensionSystem. 69 // Creates and initializes the ExtensionSystem.
70 void CreateExtensionSystem(); 70 void CreateExtensionSystem();
71 71
72 scoped_ptr<ShellBrowserContext> browser_context_; 72 scoped_ptr<ShellBrowserContext> browser_context_;
73 scoped_ptr<ShellExtensionsClient> extensions_client_; 73 scoped_ptr<ShellExtensionsClient> extensions_client_;
74 scoped_ptr<ShellExtensionsBrowserClient> extensions_browser_client_; 74 scoped_ptr<extensions::ShellExtensionsBrowserClient>
75 extensions_browser_client_;
75 76
76 // Enable a minimal set of views::corewm to be initialized. 77 // Enable a minimal set of views::corewm to be initialized.
77 scoped_ptr<wm::WMTestHelper> wm_test_helper_; 78 scoped_ptr<wm::WMTestHelper> wm_test_helper_;
78 79
79 scoped_ptr<aura::TestScreen> test_screen_; 80 scoped_ptr<aura::TestScreen> test_screen_;
80 81
81 // Owned by the BrowserContextKeyedService system. 82 // Owned by the BrowserContextKeyedService system.
82 extensions::ShellExtensionSystem* extension_system_; 83 extensions::ShellExtensionSystem* extension_system_;
83 84
84 DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts); 85 DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts);
85 }; 86 };
86 87
87 } // namespace apps 88 } // namespace apps
88 89
89 #endif // APPS_SHELL_SHELL_BROWSER_MAIN_PARTS_H_ 90 #endif // APPS_SHELL_SHELL_BROWSER_MAIN_PARTS_H_
OLDNEW
« no previous file with comments | « apps/shell/shell_browser_context.cc ('k') | apps/shell/shell_browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698