Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: apps/shell/shell_browser_context.cc

Issue 118043003: Fix app_shell shutdown crash due to BrowserContextKeyedServices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ScopedFactoryForTest (shutdown_crash) Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | apps/shell/shell_browser_main_parts.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/shell/shell_browser_context.h" 5 #include "apps/shell/shell_browser_context.h"
6 6
7 #include "apps/app_load_service_factory.h"
8
9 namespace {
10
11 // See ChromeBrowserMainExtraPartsProfiles for details.
12 void EnsureBrowserContextKeyedServiceFactoriesBuilt() {
13 apps::AppLoadServiceFactory::GetInstance();
14 }
15
16 } // namespace
17
18 namespace apps { 7 namespace apps {
19 8
20 // TODO(jamescook): Should this be an off-the-record context? 9 // Create a normal recording browser context. If we used an incognito context
21 // TODO(jamescook): Could initialize NetLog here to get logs from the networking 10 // then app_shell would also have to create a normal context and manage both.
22 // stack.
23 ShellBrowserContext::ShellBrowserContext() 11 ShellBrowserContext::ShellBrowserContext()
24 : content::ShellBrowserContext(false, NULL) { 12 : content::ShellBrowserContext(false, NULL) {
25 EnsureBrowserContextKeyedServiceFactoriesBuilt(); 13 // TODO(jamescook): Could initialize NetLog here to get logs from the
14 // networking stack.
26 } 15 }
27 16
28 ShellBrowserContext::~ShellBrowserContext() { 17 ShellBrowserContext::~ShellBrowserContext() {
29 } 18 }
30 19
31 void ShellBrowserContext::ProfileFunctionCallOnNonProfileBrowserContext1() { 20 void ShellBrowserContext::ProfileFunctionCallOnNonProfileBrowserContext1() {
32 NOTREACHED(); 21 NOTREACHED();
33 } 22 }
34 void ShellBrowserContext::ProfileFunctionCallOnNonProfileBrowserContext2() { 23 void ShellBrowserContext::ProfileFunctionCallOnNonProfileBrowserContext2() {
35 NOTREACHED(); 24 NOTREACHED();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 NOTREACHED(); 57 NOTREACHED();
69 } 58 }
70 void ShellBrowserContext::ProfileFunctionCallOnNonProfileBrowserContext14() { 59 void ShellBrowserContext::ProfileFunctionCallOnNonProfileBrowserContext14() {
71 NOTREACHED(); 60 NOTREACHED();
72 } 61 }
73 void ShellBrowserContext::ProfileFunctionCallOnNonProfileBrowserContext15() { 62 void ShellBrowserContext::ProfileFunctionCallOnNonProfileBrowserContext15() {
74 NOTREACHED(); 63 NOTREACHED();
75 } 64 }
76 65
77 } // namespace apps 66 } // namespace apps
OLDNEW
« no previous file with comments | « no previous file | apps/shell/shell_browser_main_parts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698